[5.x] Add empty/not empty filters for replicator, bard and grid #11354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it makes sense for them to extend textarea. Copy pasting a couple of arrays isn't the end of the world. |
|
OK cool, I added the same for bard as well. |
jacksleight
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds empty and not empty filter options for the replicator, bard and grid fieldtypes:
Edit:
I was about to add this to bard as well, and do another copy-paste, and then I realised these could just be added to textarea class that these three were already extending since it would work for text as well. But then I wasn't really sure if replicator extending textarea really makes sense in the first place? What do you think? Should they all use some kind of generic base class or just stick with textarea?