[6.x] Add Knip and perform some clean up #11420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added in the Vue 3 upgrade because I copied the package.json from the original Vue 3 PR. They originally used it when they migrated Popover.vue to composition API but that never needed to happen on the final PR.
This was only working because something else required it. If we use a package directly, we should require it.
…sed. Yes they were imported, but still not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Knip npm package as a way to check for unused files, dependencies, etc. Another step towards tidying up our codebase.
I also ran
npx vue-unused-components-checker.It turns out we had some Sortable components in there that weren't being used. They were being imported and added to
components, but not actually used in templates. Knip didn't pick those up because the imports were being used in the JS.