Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix issue with AssetsFieldtype upload controls hidden on @sm size #11459

Conversation

PatrickJunod
Copy link
Contributor

@PatrickJunod PatrickJunod commented Feb 16, 2025

This PR fixes an issue where the AssetsFieldtype does not show the upload controls when the field does not have enough space to be shown.

It does so by flex-wrapping the content of the .assets-fieldtype .assets-fieldtype-picker selector:

11436_480.mov

Remove extra top margin in alt text

It also removes the extra top margin in the asset upload control

Before:
image

After:
image

Fixes

Fixes #11436

@daun
Copy link
Contributor

daun commented Feb 17, 2025

I wonder if this might be improved further with an ultra-short version of the upload prompt for the small size? Could also fall back to the full-length version if not translated yet.

E.g.: "Upload or drop file" / "Hochladen oder reinziehen"

@edalzell
Copy link
Contributor

I wonder if this might be improved further with an ultra-short version of the upload prompt for the small size? Could also fall back to the full-length version if not translated yet.

E.g.: "Upload or drop file" / "Hochladen oder reinziehen"

yas plz fren

@jasonvarga
Copy link
Member

Good enough for now. This might end up changing in v6 anyway. Thanks!

@jasonvarga jasonvarga merged commit 8244b49 into statamic:5.x Feb 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset field loses upload text when 50% width on smaller viewports
4 participants