[5.x] Fix cannot use paginate/limit error when one is null #11478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10415 introduced a check to ensure that paginate and limit aren't used at the same time. However due to the
has
check anull
limit value will pass as true even though it wouldn't be applied.This becomes a problem when trying to pass variables through to tags where limit or paginate might be used:
I know you could filter the array or maybe use
void
in antlers, but it would be nice if you didn't have to worry about it. In this example there are conditions further up that ensure only one of those variables would be set.The PR changes the check to use
int
so that a null value wont pass as true. The limit param check in theresults
method also usesint
.