[5.x] Fix handle dimensions of rotated videos #11479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a rotated video so we can test this? |
|
@jasonvarga Sure! I hope GitHub preserves the meta data, but here's a video that is 1080p in portrait orientation but shows a width of FreelingWaters_Craving_for_Boijmans_video4.MOVEdit: I just checked with the video provided here, uploaded in Statamic without the fix: width: 1920
height: 1080with the fix it correctly extracts: width: 1080
height: 1920 |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the correct output of video dimensions of videos that have rotated video streams. Currently, videos with rotated streams do not output proper dimensions, width and height are swapped.
Fixes #11480