Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Remove duplicate translation line from translator command #11494

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

duncanmcclean
Copy link
Member

This pull request hopefully fixes #11489, where duplicate lines were added when running the translator command.

@duncanmcclean duncanmcclean changed the title [5.x] Remove duplicate translation line [5.x] Remove duplicate translation line from translator command Feb 24, 2025
@ebeauchamps
Copy link
Contributor

@duncanmcclean Not sure it's working as intended. I deleted the line in Translator and the untranslated line in fr.json, then I ran Translator again. My translated line is gone and there now is an untranslated line. I guess I will stick with this one, so I need to create another PR for my language file (?)

@jasonvarga
Copy link
Member

The real translation is the one with the ' and not the .

@jasonvarga jasonvarga marked this pull request as ready for review February 25, 2025 14:50
@jasonvarga jasonvarga merged commit 18c0d13 into 5.x Feb 25, 2025
17 checks passed
@jasonvarga jasonvarga deleted the double-translation branch February 25, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5.48] Found double string in fr.php translation file after running the translator command
3 participants