[5.x] Query for entry origin within the same collection #11514
Merged
+20
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix #10025
I'm honestly a bit skeptical about this fixing the issue, however in my tests, it definitely made a difference.
What I was doing was this...
In Tinkerwell, run this:
This will fire off 50 requests to the home page and output the number of each response status code.
While that's going, I would run
artisan cache:clear
from the site.Before the PR, I would fairly consistently see the routeData on null error multiple times.
After, I wouldn't see it. (I would occasionally see some other sorts of sporadic failures, but they were unrelated.)
The reason this seemingly unrelated line has anything to do with the error is because at some point along the way during building an index it needs to grab the origin. When you do
Entry::find()
(which is really justEntry::query()->where('id', $id)->first()
) it'll need to load up all theid
indexes for all collections. If you provide acollection
to an entry query, it'll only load theid
indexes for the collection(s) you pass it. In this case it'll load an index that's already loaded.