Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] More code splitting #11520

Merged
merged 5 commits into from
Mar 2, 2025
Merged

[6.x] More code splitting #11520

merged 5 commits into from
Mar 2, 2025

Conversation

jasonvarga
Copy link
Member

@jasonvarga jasonvarga commented Mar 2, 2025

  • Making NavBuilder and PageTree async components allows @he-tree/vue to be code-split.
  • Making Modal an async component and moving the css allows vue-final-modal to be split.
  • Making the TimeFieldtype an async component allows imask to be split.
  • Using dynamic imports in the Toasts class allows @hoppscotch/vue-toasted to be split.
  • Using dynamic imports in the Echo class allows laravel-echo and pusher to be split.

The $toast API methods are now technically async. But you would never really chain methods, and having a slight delay in the toast appearing doesn't hurt anything.

Before this, the js file was 2,266.68 kB │ gzip: 607.05 kB.
After these changes, the js file is 1,923.01 kB │ gzip: 509.28 kB.

@jasonvarga jasonvarga marked this pull request as ready for review March 2, 2025 21:51
@jasonvarga jasonvarga merged commit 694cb28 into master Mar 2, 2025
19 checks passed
@jasonvarga jasonvarga deleted the codesplit-2 branch March 2, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant