Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Clear selections when navigating pagination #9286

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request fixes an issue on Listing Tables where any selections would be persisted even after navigating to another page (pagination).

This change doesn't seem to affect selections in the Relationship Fieldtype. You can continue to select items across multiple pages on there.

Fixes #6767.

@jasonvarga
Copy link
Member

This doesn't affect the stack selector listing because HasPagination.js isn't used there. If we ever refactor it to use it, we'll need to add some sort of shouldResetSelectionsOnPageChange boolean somewhere.

@jasonvarga jasonvarga merged commit 85ce8fd into 4.x Jan 9, 2024
34 checks passed
@jasonvarga jasonvarga deleted the fix/clear-selections-when-paginating-in-data-list branch January 9, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data list toggle all checkbox remains checked when navigating to next page in data list
2 participants