[4.x] Fix asset meta file not being deleted with asset #9300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
deleted the
fix/asset-meta-file-not-being-deleted-alongside-asset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where an asset's
.metafile would not be deleted when the asset itself was deleted.Although the meta file was actually deleted, it was shortly after being re-created by the
UpdateAssetReferenceslistener which calls thegetOriginal()method on theAsset, which ended up callingmeta()and because of a meta file not being found for the asset, it created one.This PR attempts to fix that issue by checking if the asset itself actually exists before writing the meta file to disk. If one doesn't exist, it'll now just return an empty meta array.
Fixes #7042.