Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Prevent Bard causing dirty state issues #9344

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[4.x] Prevent Bard causing dirty state issues #9344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion resources/js/components/fieldtypes/bard/BardFieldtype.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,13 +367,17 @@ export default {
json(json) {
if (!this.mounted) return;

let jsonValue = JSON.stringify(json);

if (jsonValue === this.value) return;

// Prosemirror's JSON will include spaces between tags.
// For example (this is not the actual json)...
// "<p>One <b>two</b> three</p>" becomes ['OneSPACE', '<b>two</b>', 'SPACEthree']
// But, Laravel's TrimStrings middleware would remove them.
// Those spaces need to be there, otherwise it would be rendered as <p>One<b>two</b>three</p>
// To combat this, we submit the JSON string instead of an object.
this.updateDebounced(JSON.stringify(json));
this.updateDebounced(jsonValue);
},

value(value, oldValue) {
Expand Down
Loading