[4.x] Update entry order and uri by ids #9350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliawarnke
changed the title
jasonvarga
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Thank you for this. Great PR!
In response to your question in the issue:
Is there a reason why the existing method updateItem in the Index class is not used?
No. I believe we started passing in the $ids in order to improve performance on the Eloquent driver, and the existing code in here just continued working. We should have done this too though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9236
Right now when saving changes in the collection tree the uri index and order index will be rebuild completely, even though the specific ids are passed as a parameter.
This causes performance issues when having a lot of entries.
This PR fixes that and updates only the affected parts.