[4.x] fix some translations #9361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
approved these changes
Jan 19, 2024
Send field name as param instead of concating it.
peimn
changed the title
Make headers of sites table translatable in global section
Translate Pro and Free tip on logo and section titles on licensing page
Some languages like Arabic and Persian need translations for units
|
It looks like you're still adding translations - I'm going to mark this PR as a draft for now. Feel free to mark "ready for review" once you've finished all your changes. |
duncanmcclean
requested changes
Jan 19, 2024
jasonvarga
reviewed
Jan 19, 2024
That space needs to be removed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes some placeholders translatable in Bard fieldtype.
Send field name as param instead of concating it in slug fieldtype.
Make headers of sites table translatable in global section.
Translate Pro and Free tip on logo and section titles on licensing page.
Translate units. There are some languages that require unit translations, such as Arabic and Persian.