-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Remove redundant config options from blueprint YAML #9685
Merged
jasonvarga
merged 15 commits into
master
from
remove-redundant-config-options-from-blueprint-yaml
Mar 18, 2024
Merged
[5.x] Remove redundant config options from blueprint YAML #9685
jasonvarga
merged 15 commits into
master
from
remove-redundant-config-options-from-blueprint-yaml
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
requested changes
Mar 8, 2024
jasonvarga
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you see if you can get icon: null
and instructions: null
get filtered out of replicator/bard groups/sets? Seems relevant to this PR.
-
handle: replicator_field
field:
type: replicator
display: 'Replicator Field'
sets:
new_set_group:
display: 'New Set Group'
instructions: null
icon: null
sets:
new_set:
display: 'New Set'
instructions: null
icon: null
fields: { }
…nfig-options-from-blueprint-yaml # Conflicts: # src/Http/Controllers/CP/Fields/FieldsController.php
… github.com:statamic/cms into remove-redundant-config-options-from-blueprint-yaml
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to prevent config options from being saved in field configs when the values match the default config values for the fieldtype.
This PR also does a little bit of refactoring, moving all the
Arr::get()
/unset
stuff into the->reject()
method. I've also added some tests to ensure my changes don't break anything. 😄Closes #9431.