[5.x] Add pluck to query builder #9686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation will resolve values from the Stache indexes
I think this is fine. We could justify it as the same thing happening with Eloquent models and accessors. Calling class Post extends Model
{
protected function formattedTitle(): Attribute
{
return Attribute::make(
get: fn ($value, $attributes) => Str::title($attributes['title']),
);
}
}
Post::query()->pluck('title'); // ['post one', 'post two']
Post::query()->pluck('formattedTitle'); // QueryException Unknown column formattedTitle
Post::query()->get()->pluck('formattedTitle'); // ['Post One', 'Post Two'] |
edalzell
reviewed
Mar 25, 2024
edalzell
reviewed
Mar 25, 2024
edalzell
reviewed
Mar 25, 2024
jasonvarga
requested changes
Mar 25, 2024
- make getItemValues abstract like getItem is. - move implementation into BasicStore like getItem - aggregatestore version delegates to individual stores like getitem - prevent the query builder from doing Str::after the divider, now that the aggregatestore handles that - add test to entry query builder test with multiple collections to show it works - use id- prefix for ids in test to make it more obvious what are keys vs just array indexes. its confusing when debugging.
jasonvarga
approved these changes
Mar 29, 2024
- make private as its only used in one place now. - adjust comment - use 'filter' since 'where' calls filter anyway
jasonvarga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
pluckmethod on the query builder.Note: this implementation currently only resolves values from the Stache indexes, but a fallback to gathering data from entry instances could also be added if desired 🙂