Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add ability to specify which Stache stores to warm #9694

Closed
wants to merge 1 commit into from
Closed

[5.x] Add ability to specify which Stache stores to warm #9694

wants to merge 1 commit into from

Conversation

JohnathonKoster
Copy link
Contributor

@JohnathonKoster JohnathonKoster commented Mar 10, 2024

This PR adds the ability to specify which Stache store to warm. It can be used like so:

Warm all stores:

php please stache:warm

Warm a single store:

php please stache:warm global-variables

Warm a set of stores:

php please stache:warm globals,global-variables

@jasonvarga
Copy link
Member

What's the intention behind only warming certain stores?

@ryanmitchell
Copy link
Contributor

ryanmitchell commented Mar 19, 2024

If its ok to chip in here, it would be useful from the eloquent side, as currently the warm command doesnt check if eloquent is being used so if you have yaml files in your store location they do get warmed, which can cause duplicate id messages.

@jasonvarga
Copy link
Member

That seems like a different problem though. If you are using eloquent just for entries and you want to warm the stache, you're saying that you'll need to specify every other store manually?

@ryanmitchell
Copy link
Contributor

Yep - I guess an exclude might be nice (or for it just to be smarter and not warm those)

@jasonvarga
Copy link
Member

John if you wanna chime on why this is important, we can reopen this one. 👍

@jasonvarga jasonvarga closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants