Skip to content

Conversation

@duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Nov 21, 2024

This pull request adds PHP 8.4 support. Requires statamic/cms#11114.

@duncanmcclean duncanmcclean marked this pull request as draft November 21, 2024 10:47
"spatie/simple-excel": "^3.7",
"symfony/dom-crawler": "^7.1",
"pixelfear/composer-dist-plugin": "^0.1.5",
"laravel/framework": "11.*"
Copy link
Member Author

@duncanmcclean duncanmcclean Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #21, whilst fixing some Testbench-related things, I accidentally added a requirement for Laravel 11.

This PR reverts that so you can use Laravel 10 & 11.

@duncanmcclean duncanmcclean marked this pull request as ready for review November 28, 2024 20:40
@duncanmcclean duncanmcclean marked this pull request as draft November 28, 2024 20:46
@duncanmcclean duncanmcclean marked this pull request as ready for review November 29, 2024 10:40
@duncanmcclean duncanmcclean merged commit 86fb0ca into main Nov 29, 2024
20 checks passed
@duncanmcclean duncanmcclean deleted the php84 branch November 29, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants