chore!: cleanup wallet activity code #6168
Open
+554
−6,253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (221)
|
dlipicar
force-pushed
the
chore/cleanup-deprecated-activity-code
branch
from
00a5c59 to
7b80b62
Compare
dlipicar
changed the title
dlipicar
force-pushed
the
chore/cleanup-deprecated-activity-code
branch
2 times, most recently
from
8bfbc5e to
7f145f0
Compare
dlipicar
force-pushed
the
chore/cleanup-deprecated-activity-code
branch
2 times, most recently
from
8837789 to
b684c7d
Compare
dlipicar
changed the title
dlipicar
force-pushed
the
chore/cleanup-deprecated-activity-code
branch
3 times, most recently
from
0ca933f to
357d0fc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6168 +/- ##
============================================
+ Coverage 23.92% 60.71% +36.79%
============================================
Files 801 840 +39
Lines 104713 106940 +2227
============================================
+ Hits 25051 64928 +39877
+ Misses 76193 34439 -41754
- Partials 3469 7573 +4104
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dlipicar
force-pushed
the
chore/cleanup-deprecated-activity-code
branch
2 times, most recently
from
f746203 to
0251a94
Compare
|
Looks like you have BREAKING CHANGES in your PR. Check-list
|
dlipicar
force-pushed
the
chore/cleanup-deprecated-activity-code
branch
13 times, most recently
from
2b85744 to
e75dc4c
Compare
dlipicar
requested review from
antdanchenko,
saledjenic,
alaibe,
a team and
briansztamfater
dlipicar
changed the title
saledjenic
approved these changes
Mar 4, 2025
dlipicar
force-pushed
the
chore/cleanup-deprecated-activity-code
branch
from
e75dc4c to
b1e8bae
Compare
briansztamfater
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
I checked and I didn't find any usage of the removed endpoints in status-mobile. Would be great if @smohamedjavid could double check as he worked on activity integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused wallet API endpoints and associated code
Removed API endpoints:
CheckRecentHistoryCheckRecentHistoryForChainIDsUsed to be called manually after sending a transaction, this is now triggered automatically in status-go
LoadTransferByHashCreateMultiTransactionUsed for old wallet and community transactions
GetTransfersByAddressGetTransfersByAddressAndChainIDGetTransfersForIdentitiesGetPendingTransactionsForIdentitiesFilterActivityAsyncCancelActivityFilterTaskUsed for the pre-session activity screen
StartActivityFilterSessionGetMultiTxDetailsUsed for sessionV1 activity