fix_: cancel request to join to a community #6360
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (41)
|
ilmotta
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Ran the test suite and nothing broke.
@ulisesmac I imagine this is because the tests, like TestCancelRequestAccess are not not asserting the message was sent to each privileged member using the sender's identity, which I understood is what the fix is now forcing by setting the Sender to nil.
ulisesmac
force-pushed
the
cancel-request-to-join-communities
branch
3 times, most recently
from
c0ff445 to
14059e4
Compare
qfrank
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
LGTM. I see you're facing jenkins/prs/tests failure, pls rebase your PR which should improve your XP now. @ulisesmac
ulisesmac
force-pushed
the
cancel-request-to-join-communities
branch
from
14059e4 to
cbad454
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6360 +/- ##
===========================================
+ Coverage 61.02% 61.04% +0.02%
===========================================
Files 843 843
Lines 108209 108210 +1
===========================================
+ Hits 66034 66061 +27
+ Misses 34541 34526 -15
+ Partials 7634 7623 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ilmotta
approved these changes
Mar 3, 2025
ulisesmac
force-pushed
the
cancel-request-to-join-communities
branch
from
cbad454 to
1d713e4
Compare
osmaczko
approved these changes
Mar 14, 2025
ulisesmac
force-pushed
the
cancel-request-to-join-communities
branch
from
1d713e4 to
8149807
Compare
|
Tested by QA and approved here: So the PR is going to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue originally reported here:
Where the "cancel request to join" action threw an error,
Ran the test suite and nothing broke.
Thanks to @osmaczko for the solution