Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wallet)_: token related types moved from the token to tokentypes package #6397

Merged
merged 1 commit into from
Mar 14, 2025
Merged

chore(wallet)_: token related types moved from the token to tokentypes package #6397

merged 1 commit into from
Mar 14, 2025

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented Mar 7, 2025 •
edited
Loading

This change is needed for the upcoming PR, which will auto-refresh token lists.

The following types are moved from services/wallet/token to services/wallet/token/types location:

  • Token
  • StorageToken
  • TokenMarketValues
  • ChainBalance

Need for the follow-up PR:

@status-im-auto
Copy link
Member

status-im-auto commented Mar 7, 2025 •
edited
Loading

Jenkins Builds

Click to see older builds (8)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 50c78ab #1 2025-03-07 10:12:46 ~2 min ios 📦zip
✔️ 50c78ab #1 2025-03-07 10:13:04 ~3 min android 📦aar
✔️ 50c78ab #1 2025-03-07 10:14:03 ~4 min macos 📦zip
✔️ 50c78ab #1 2025-03-07 10:15:25 ~5 min linux 📦zip
✔️ 50c78ab #1 2025-03-07 10:15:31 ~5 min macos 📦zip
✔️ 50c78ab #1 2025-03-07 10:16:09 ~6 min windows 📦zip
✔️ 50c78ab #1 2025-03-07 10:29:04 ~19 min tests-rpc 📄log
✔️ 50c78ab #1 2025-03-07 10:42:17 ~32 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ de0da7b #2 2025-03-07 14:02:26 ~3 min android 📦aar
✔️ de0da7b #2 2025-03-07 14:02:29 ~3 min ios 📦zip
✔️ de0da7b #2 2025-03-07 14:03:46 ~4 min windows 📦zip
✔️ de0da7b #2 2025-03-07 14:05:05 ~5 min macos 📦zip
✔️ de0da7b #2 2025-03-07 14:05:29 ~6 min macos 📦zip
✔️ de0da7b #2 2025-03-07 14:05:47 ~6 min linux 📦zip
✔️ de0da7b #2 2025-03-07 14:16:35 ~17 min tests-rpc 📄log
✔️ de0da7b #2 2025-03-07 14:31:42 ~32 min tests 📄log
✔️ e2c3932 #3 2025-03-13 13:20:58 ~3 min android 📦aar
✔️ e2c3932 #3 2025-03-13 13:21:09 ~3 min ios 📦zip
✔️ e2c3932 #3 2025-03-13 13:22:37 ~4 min macos 📦zip
✔️ e2c3932 #3 2025-03-13 13:23:18 ~5 min windows 📦zip
✔️ e2c3932 #3 2025-03-13 13:23:19 ~5 min macos 📦zip
✔️ e2c3932 #3 2025-03-13 13:23:48 ~5 min linux 📦zip
✔️ e2c3932 #3 2025-03-13 13:39:12 ~21 min tests-rpc 📄log
✔️ e2c3932 #3 2025-03-13 13:52:40 ~34 min tests 📄log

@codecov Codecov
Copy link

codecov bot commented Mar 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.64497% with 35 lines in your changes missing coverage. Please review.

Project coverage is 60.95%. Comparing base (0ab8844) to head (e2c3932).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
services/wallet/token/token.go 73.17% 11 Missing ⚠️
services/wallet/api.go 16.66% 5 Missing ⚠️
services/wallet/token/analyzer/main.go 0.00% 5 Missing ⚠️
services/wallet/router/router_helper.go 33.33% 4 Missing ⚠️
services/wallet/onramp/provider_mercuryo.go 0.00% 2 Missing ⚠️
...allet/router/pathprocessor/processor_bridge_hop.go 0.00% 2 Missing ⚠️
services/wallet/token/downloader/main.go 0.00% 2 Missing ⚠️
services/wallet/transfer/testutils.go 50.00% 2 Missing ⚠️
protocol/communities/manager.go 0.00% 1 Missing ⚠️
...es/wallet/router/pathprocessor/processor_erc721.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #6397      +/-   ##
===========================================
- Coverage    61.00%   60.95%   -0.05%     
===========================================
  Files          842      843       +1     
  Lines       108169   108169              
===========================================
- Hits         65988    65937      -51     
- Misses       34556    34598      +42     
- Partials      7625     7634       +9
Flag Coverage Δ
functional 23.86% <56.49%> (-0.04%) ⬇️
unit 59.17% <84.91%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
services/wallet/activity/activity_v2.go 74.01% <100.00%> (ø)
services/wallet/reader.go 78.71% <100.00%> (ø)
services/wallet/requests/router_input_params.go 22.91% <ø> (ø)
services/wallet/router/router.go 75.54% <100.00%> (ø)
services/wallet/router/router_test_data.go 100.00% <100.00%> (ø)
services/wallet/router/routes/router_path.go 86.17% <100.00%> (ø)
services/wallet/token/aave_tokenstore.go 100.00% <100.00%> (ø)
services/wallet/token/balance_persistence.go 76.78% <100.00%> (ø)
services/wallet/token/tokenstore.go 100.00% <100.00%> (ø)
services/wallet/token/types/token.go 100.00% <100.00%> (ø)
... and 11 more

... and 29 files with indirect coverage changes

@saledjenic saledjenic requested a review from shivekkhurana March 7, 2025 11:47
@saledjenic saledjenic mentioned this pull request Mar 7, 2025
Open
@saledjenic saledjenic changed the title chore(wallet): token related types moved from the token to tokentypes package chore(wallet)_: token related types moved from the token to tokentypes package Mar 7, 2025
@saledjenic saledjenic force-pushed the chore/move-token-types branch from 50c78ab to de0da7b Compare March 7, 2025 13:59
friofry
friofry approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@friofry friofry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks for extracting this refactoring into a separate PR.

@saledjenic
chore(wallet)_: token related types moved from the token to tokentype…
e2c3932 
…s package

Moved types:
- `Token`
- `StorageToken`
- `TokenMarketValues`
- `ChainBalance`
@saledjenic saledjenic force-pushed the chore/move-token-types branch from de0da7b to e2c3932 Compare March 13, 2025 13:17
@saledjenic saledjenic merged commit f4a1e88 into develop Mar 14, 2025
19 checks passed
@saledjenic saledjenic deleted the chore/move-token-types branch March 14, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaibe alaibe alaibe approved these changes

@friofry friofry friofry approved these changes

@dlipicar dlipicar Awaiting requested review from dlipicar

@Cuteivist Cuteivist Awaiting requested review from Cuteivist

@briansztamfater briansztamfater Awaiting requested review from briansztamfater

@shivekkhurana shivekkhurana Awaiting requested review from shivekkhurana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saledjenic @status-im-auto @alaibe @friofry