Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: moving shard module to wakuv2 #6412

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Mar 12, 2025

Moving shard.go to the wakuv2 package. The sharding logic belongs to Waku usage and moving it allows us avoiding circular dependencies.

Important changes:

  • moving shard.go to wakuv2 package
  • updating imports

Issue: waku-org/nwaku#3076

Sorry, something went wrong.

@status-im-auto
Copy link
Member

status-im-auto commented Mar 12, 2025

Jenkins Builds

Click to see older builds (16)
Commit #️⃣ Finished (UTC) Duration Platform Result
920e7cb #1 2025-03-12 13:56:37 ~1 min android 📄log
920e7cb #1 2025-03-12 13:56:46 ~1 min ios 📄log
✖️ 920e7cb #1 2025-03-12 13:56:46 ~1 min tests 📄log
920e7cb #1 2025-03-12 13:56:56 ~1 min macos 📄log
920e7cb #1 2025-03-12 13:57:10 ~1 min linux 📄log
920e7cb #1 2025-03-12 13:57:44 ~2 min windows 📄log
920e7cb #1 2025-03-12 13:57:46 ~2 min macos 📄log
✖️ 920e7cb #1 2025-03-12 14:13:08 ~17 min tests-rpc 📄log
578f8fb #2 2025-03-12 14:04:18 ~2 min ios 📄log
578f8fb #2 2025-03-12 14:04:44 ~2 min android 📄log
578f8fb #2 2025-03-12 14:05:03 ~2 min macos 📄log
578f8fb #2 2025-03-12 14:05:09 ~2 min windows 📄log
578f8fb #2 2025-03-12 14:05:29 ~3 min linux 📄log
✖️ 578f8fb #2 2025-03-12 14:05:42 ~3 min tests 📄log
578f8fb #2 2025-03-12 14:05:44 ~3 min macos 📄log
✖️ 578f8fb #2 2025-03-12 14:32:49 ~19 min tests-rpc 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bc7d6eb #3 2025-03-12 14:22:20 ~3 min ios 📦zip
✔️ bc7d6eb #3 2025-03-12 14:22:27 ~3 min android 📦aar
✔️ bc7d6eb #3 2025-03-12 14:22:28 ~3 min windows 📦zip
✔️ bc7d6eb #3 2025-03-12 14:23:54 ~4 min macos 📦zip
✔️ bc7d6eb #3 2025-03-12 14:25:25 ~6 min linux 📦zip
✔️ bc7d6eb #3 2025-03-12 14:26:27 ~7 min macos 📦zip
✔️ bc7d6eb #3 2025-03-12 14:53:07 ~20 min tests-rpc 📄log
✔️ bc7d6eb #3 2025-03-12 14:55:03 ~35 min tests 📄log
✔️ 97926c1 #4 2025-03-12 14:52:04 ~2 min ios 📦zip
✔️ 97926c1 #4 2025-03-12 14:52:05 ~2 min android 📦aar
✔️ 97926c1 #4 2025-03-12 14:52:23 ~3 min windows 📦zip
✔️ 97926c1 #4 2025-03-12 14:53:43 ~4 min macos 📦zip
✔️ 97926c1 #4 2025-03-12 14:54:33 ~5 min linux 📦zip
✔️ 97926c1 #4 2025-03-12 14:55:05 ~5 min macos 📦zip
✔️ 97926c1 #4 2025-03-12 15:12:41 ~19 min tests-rpc 📄log
✖️ 97926c1 #4 2025-03-12 15:30:35 ~35 min tests 📄log
✔️ 97926c1 #5 2025-03-12 16:25:49 ~33 min tests 📄log
✔️ 97926c1 #5 2025-03-12 18:13:38 ~17 min tests-rpc 📄log
✔️ 97926c1 #6 2025-03-12 18:29:46 ~33 min tests 📄log

@gabrielmer gabrielmer self-assigned this Mar 12, 2025
@gabrielmer gabrielmer force-pushed the chore-moving-shard-to-wakuv2 branch from bc7d6eb to 97926c1 Compare March 12, 2025 14:48
@gabrielmer gabrielmer marked this pull request as ready for review March 12, 2025 17:47
@gabrielmer
Copy link
Contributor Author

The codecov CI checks are taking hours and doesn't let me retrigger them - is this expected?

@igor-sirotin
Copy link
Collaborator

igor-sirotin commented Mar 12, 2025

The codecov CI checks are taking hours and doesn't let me retrigger them - is this expected?

This seem to happen once in a while, but quite rare. I couldn't figure out the issue.
I've restarted the tests in your PR, this should help.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.

Project coverage is 61.03%. Comparing base (9e769ce) to head (97926c1).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
cmd/ping-community/main.go 0.00% 2 Missing ⚠️
services/ext/api.go 0.00% 2 Missing ⚠️
protocol/communities/community.go 66.66% 1 Missing ⚠️
protocol/communities/manager.go 87.50% 1 Missing ⚠️
protocol/linkpreview_unfurler_status.go 50.00% 1 Missing ⚠️
protocol/messenger_filter_init.go 0.00% 0 Missing and 1 partial ⚠️
protocol/requests/set_community_shard.go 0.00% 0 Missing and 1 partial ⚠️
services/status/service.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6412       +/-   ##
============================================
+ Coverage    23.84%   61.03%   +37.19%     
============================================
  Files          801      842       +41     
  Lines       104698   108161     +3463     
============================================
+ Hits         24961    66012    +41051     
+ Misses       76284    34541    -41743     
- Partials      3453     7608     +4155     
Flag Coverage Δ
functional 23.89% <31.91%> (+0.05%) ⬆️
unit 59.26% <77.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
node/status_node_services.go 79.59% <100.00%> (+6.12%) ⬆️
protocol/communities/persistence.go 71.09% <100.00%> (+54.43%) ⬆️
protocol/communities/persistence_mapping.go 82.85% <100.00%> (+29.52%) ⬆️
protocol/messenger_communities.go 52.41% <100.00%> (+48.56%) ⬆️
protocol/messenger_community_shard.go 77.77% <100.00%> (+44.44%) ⬆️
protocol/messenger_share_urls.go 66.47% <100.00%> (+66.47%) ⬆️
protocol/messenger_store_node_request_manager.go 72.99% <100.00%> (+2.55%) ⬆️
protocol/transport/filters_manager.go 76.04% <100.00%> (+21.09%) ⬆️
wakuv2/config.go 100.00% <100.00%> (+69.23%) ⬆️
wakuv2/shard.go 100.00% <ø> (ø)
... and 8 more

... and 612 files with indirect coverage changes

@gabrielmer gabrielmer merged commit 0ab8844 into develop Mar 13, 2025
20 checks passed
@gabrielmer gabrielmer deleted the chore-moving-shard-to-wakuv2 branch March 13, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants