Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_: avoid to use fixed port value 60000 as waku v2 listen port #6424

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Mar 14, 2025

This PR updated the sample database file 0x7c46c8f6f059ab72d524f2a6d356904db30bb0392636172ab3929a6bd2220f84.db, modifying the wakuv2_config.port value from 60000 to 0 to enable the use of a random port instead of a fixed one, reducing the likelihood of port conflicts.

close #6423

@qfrank qfrank requested review from ilmotta and igor-sirotin March 14, 2025 06:46
@qfrank qfrank self-assigned this Mar 14, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Mar 14, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d6c8c23 #1 2025-03-14 06:49:52 ~3 min ios 📦zip
✔️ d6c8c23 #1 2025-03-14 06:50:02 ~3 min android 📦aar
✔️ d6c8c23 #1 2025-03-14 06:51:35 ~4 min macos 📦zip
✔️ d6c8c23 #1 2025-03-14 06:52:07 ~5 min macos 📦zip
✔️ d6c8c23 #1 2025-03-14 06:53:01 ~6 min windows 📦zip
✔️ d6c8c23 #1 2025-03-14 06:53:36 ~6 min linux 📦zip
✔️ d6c8c23 #1 2025-03-14 07:06:08 ~19 min tests-rpc 📄log
✔️ d6c8c23 #1 2025-03-14 07:23:02 ~36 min tests 📄log

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.05%. Comparing base (b3f0758) to head (d6c8c23).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6424       +/-   ##
============================================
+ Coverage    23.92%   61.05%   +37.12%     
============================================
  Files          801      842       +41     
  Lines       104713   108176     +3463     
============================================
+ Hits         25051    66045    +40994     
+ Misses       76193    34514    -41679     
- Partials      3469     7617     +4148     
Flag Coverage Δ
functional 23.91% <ø> (-0.02%) ⬇️
unit 59.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 630 files with indirect coverage changes

@igor-sirotin igor-sirotin merged commit e773c7b into develop Mar 14, 2025
20 checks passed
@igor-sirotin igor-sirotin deleted the frank/fix/conflict_port_60000 branch March 14, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test TestLoginAndMigrationsStillWorkWithExistingDesktopUser
4 participants