Skip to content

Conversation

@jkbktl
Copy link
Contributor

@jkbktl jkbktl commented Oct 1, 2025

  • static data (waiting for API)

closes #776

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2025

🦋 Changeset detected

Latest commit: 5c27ca9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@status-im/status-network Patch
hub Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jkbktl jkbktl self-assigned this Oct 1, 2025
@vercel
Copy link

vercel bot commented Oct 1, 2025

@jkbktl is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@jkbktl jkbktl linked an issue Oct 1, 2025 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
status-network-hub Ready Ready Preview Comment Oct 5, 2025 10:49pm

@jkbktl jkbktl marked this pull request as ready for review October 2, 2025 13:32
@jkbktl jkbktl requested a review from Copilot October 2, 2025 13:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new "Discover" section that displays curated dApps and services built on Status Network. The changes introduce a comprehensive app discovery interface with filtering, categorization, and enhanced visual design.

  • Adds data structures and UI components for app discovery with static data
  • Implements filtering by popularity, new apps, and categories
  • Creates enhanced app card components with cover images and social links

Reviewed Changes

Copilot reviewed 10 out of 31 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/status-network/src/components/button/index.tsx Adds new 'grey' button variant with hover states
apps/hub/tailwind.config.ts Adds skeleton animation keyframes and configuration
apps/hub/src/types/app.ts Defines TypeScript interfaces for App, Category, and Tab
apps/hub/src/data/featured-apps.ts Static data for featured apps display
apps/hub/src/data/apps.ts Static data for all apps with filtering properties
apps/hub/src/constants/tabs.ts Tab configuration for Popular/New/All filters
apps/hub/src/constants/categories.ts Category definitions with emoji labels
apps/hub/src/app/discover/page.tsx Main discover page with filtering and layout
apps/hub/src/app/_components/app-card.tsx Enhanced app card component with images and skeleton loader
.changeset/friendly-cats-draw.md Changeset documentation for the feature

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jkbktl jkbktl requested a review from nonuwa-oss October 5, 2025 22:54
@jkbktl jkbktl force-pushed the feat/wallet-connect branch from 99fde63 to f2e7acf Compare October 7, 2025 15:52
@jkbktl jkbktl deleted the branch status-im:main October 16, 2025 11:40
@jkbktl jkbktl closed this Oct 16, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web & User Interfaces Oct 16, 2025
@jkbktl jkbktl reopened this Oct 16, 2025
@github-project-automation github-project-automation bot moved this from Done to Backlog in Web & User Interfaces Oct 16, 2025
@jkbktl jkbktl moved this from Backlog to In Progress in Web & User Interfaces Oct 16, 2025
@jkbktl jkbktl changed the base branch from feat/wallet-connect to main October 16, 2025 11:52
Copy link

@JulesFiliot JulesFiliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

const ConnectButton = (props: Props) => {
const { size = '32', label = 'Connect wallet' } = props

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add two constants like DEFAULT_SIZE, DEFAULT_LABEL if we are picky

@github-project-automation github-project-automation bot moved this from In Progress to Waiting in Web & User Interfaces Oct 22, 2025
Copy link
Contributor

@jinhojang6 jinhojang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @JulesFiliot, I've clicked the Re-request review button by mistake.

The PR looks good to me if i18n doesn’t matter at this point, the merge conflict will be resolved, and Jules' suggestion will be applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting

Development

Successfully merging this pull request may close these issues.

add discover section

5 participants