feat: Add UI and hooks for pre-deposit functionality #816
Conversation
- Added useApprovePreDepositToken hook for token approval process. - Implemented useExchangeRate hook to fetch token exchange rates from Binance. - Developed useMaxPreDepositValue hook to read maximum deposit amount for a user. - Introduced usePreDepositStateContext and usePreDepositStateMachine for managing pre-deposit state. - Created usePreDepositVault hook for depositing tokens into a vault. - Updated DashboardPage to include vault selection and pre-deposit modal.
|
|
@gbonumore is attempting to deploy a commit to the Status Team on Vercel. A member of the Team first needs to authorize it. |
felicio
requested review from
a team,
JulesFiliot,
felicio,
jinhojang6 and
jkbktl
| const { name, apy, rewards, icon, onDeposit } = props | ||
| const apyValue = apy.endsWith('%') ? apy.slice(0, -1) : apy | ||
| const rewardsLine = rewards.join(', ') | ||
| const rewardsLine = rewards.map(reward => reward.name).join(', ') |
There was a problem hiding this comment.
what are the chances that reward.name is not undefined?
There was a problem hiding this comment.
this is defined by us, since it's required this would not compile
| .with({ exchangeRate: P.nullish }, () => 0) | ||
| .with({ amountInputNumber: P.when(n => isNaN(n) || n <= 0) }, () => 0) | ||
| .with({ calculatedUSD: P.when(n => !isFinite(n)) }, () => null) | ||
| .with({ calculatedUSD: P.when(n => n > 1_000_000_000_000) }, () => null) |
There was a problem hiding this comment.
There must be a good reason but why 1_000_000_000_000 specifically?
There was a problem hiding this comment.
This is to avoid insanely dollar values and do useless api calls, so this check might not be even here (this is more or less the same UX swap protocols offer when you try to input unreal money) feel free to change this number to a fair value that doesn't break UI or directly on the API call to prevent the call to be fired
| enabled, | ||
| refetchInterval, | ||
| staleTime, | ||
| retry: 3, |
There was a problem hiding this comment.
This is indeed you might want to setup default retries on the queryclient config
| options: Omit<FormatTokenOptions, 'tokenDecimals'> = {} | ||
| ): string { | ||
| return formatTokenAmount(amount, 'ETH', { | ||
| decimals: 4, // Default to 4 decimals for ETH |
There was a problem hiding this comment.
This file comes from #811 so you guys want to address these on that PR first
| ): string { | ||
| return formatTokenAmount(amount, 'KARMA', { | ||
| ...options, | ||
| tokenDecimals: 0, // KARMA values are already in display units |
| ): string { | ||
| const { | ||
| currency = 'USD', | ||
| tokenDecimals = 0, // Default to 0 for currency values (already in display units) |
Co-authored-by: Onuwa Nnachi Isaac <[email protected]>
Co-authored-by: Onuwa Nnachi Isaac <[email protected]>
Co-authored-by: Onuwa Nnachi Isaac <[email protected]>
github-project-automation
bot
moved this from In Progress
to ToDo
in Web & User Interfaces
3 participants
closes #775