Skip to content

update wallet connect #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 5, 2025
Merged

update wallet connect #828

merged 6 commits into from
Nov 5, 2025

Conversation

@felicio
Copy link
Collaborator

@felicio felicio commented Nov 4, 2025 •
edited
Loading

OP: #821

Copilot AI review requested due to automatic review settings November 4, 2025 13:04
@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 9e31981

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hub Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
status-api Ignored Ignored Preview Nov 5, 2025 5:24am
status-components Ignored Ignored Preview Nov 5, 2025 5:24am
status-network-hub Ignored Ignored Preview Nov 5, 2025 5:24am
status-portfolio Ignored Ignored Preview Nov 5, 2025 5:24am

Copilot AI reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive Web3 staking functionality to the hub application, including wallet integration, vault management, and multiplier points system. The changes enable users to stake SNT tokens, manage vaults, and earn multiplier points through a fully functional UI.

  • Integrates Wagmi, ConnectKit, and SIWE for Web3 wallet connectivity and authentication
  • Implements a state machine for vault operations (staking, withdrawing, locking, compounding)
  • Adds comprehensive utility functions for currency/token formatting and vault calculations
  • Updates dependencies including @scure/base from ^1.1.1 to ^1.2.6 across multiple packages

Reviewed Changes

Copilot reviewed 72 out of 79 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pnpm-lock.yaml Updated package lock with new Web3 dependencies and version bumps
package.json Added Web3 dependencies at root level and updated overrides
apps/hub/package.json Added staking-related dependencies and form management libraries
apps/hub/tsconfig.json Added path aliases for hooks, constants, and utils
apps/hub/src/app/stake/page.tsx Complete staking page implementation with vault selection and management
apps/hub/src/app/_providers/index.tsx Consolidated provider setup with proper hierarchy for Web3 and state management
apps/hub/src/app/_hooks/* Multiple custom hooks for vault operations, staking, withdrawals, and MP calculations
apps/hub/src/utils/* Utility functions for currency formatting, address shortening, and vault calculations
apps/hub/src/app/_constants/index.ts Central export for application constants
packages/status-network/* Button variant additions and color system integration
packages/components/* Toast component fix and ButtonProps export
packages/status-js/package.json Updated @scure/base dependency
packages/portfolio/package.json Updated @scure/base dependency
Comments suppressed due to low confidence (1)

apps/hub/src/app/_providers/query-client-provider.tsx:1

  • [nitpick] This file is deleted but the QueryClient configuration is duplicated in apps/hub/src/app/_providers/index.tsx. Consider extracting the QueryClient configuration to a separate constant file to avoid duplication and make the configuration reusable if needed elsewhere.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/components/src/toast/toast.tsx
Comment on lines 49 to 53
{onAction && (
<Close>
<CloseIcon className="cursor-pointer text-white-100" />
</Close>
)}
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The close button is only rendered when onAction is truthy. This means toasts without action buttons cannot be closed manually. The close button should always be available, or this conditional should check for a separate showClose prop.

Copilot uses AI. Check for mistakes.
apps/hub/src/app/stake/page.tsx
Comment on lines 206 to 208
} catch {
sendVaultEvent({ type: 'REJECT' })
} finally {
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty catch block swallows errors without logging. Add error logging or at minimum add a comment explaining why the error is intentionally ignored. This makes debugging production issues difficult.

Copilot uses AI. Check for mistakes.
@felicio felicio force-pushed the update-wallet-connect-impl branch from c909463 to fe9e7cb Compare November 4, 2025 13:09
@felicio felicio changed the base branch from main to release/hub November 4, 2025 13:13
@felicio felicio changed the base branch from release/hub to main November 4, 2025 13:14
@felicio felicio requested review from a team, JulesFiliot, iamonuwa, jinhojang6 and jkbktl November 4, 2025 13:22
jkbktl
jkbktl reviewed Nov 4, 2025
View reviewed changes
apps/hub/.env Outdated


NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID="123"
NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID="7ab664eee6a734b14327cdf4678a3431"
Copy link
Contributor

@jkbktl jkbktl Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flagging this once again just for the record

Copy link
Collaborator Author

@felicio felicio Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#820 (comment)

Copy link
Collaborator Author

@felicio felicio Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamonuwa

Copy link
Collaborator Author

@felicio felicio Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4c4e45b

Copy link
Collaborator Author

@felicio felicio Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's public, so committing wouldn't hurt. But more importantly perhaps it differs from what @jkbktl added to Vercel and what @iamonuwa used here.

jkbktl
jkbktl approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@jkbktl jkbktl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ pre-approving

@github-project-automation github-project-automation bot moved this from In Progress to Waiting in Web & User Interfaces Nov 4, 2025
felicio
felicio commented Nov 5, 2025
View reviewed changes
apps/hub/.env

NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID="123"
NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID=""
NEXT_PUBLIC_STATUS_NETWORK_API_URL=""
Copy link
Collaborator Author

@felicio felicio Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@status-im/web fyi, rename from NEXT_PUBLIC_API_URL to NEXT_PUBLIC_STATUS_NETWORK_API_URL

@felicio
Copy link
Collaborator Author

felicio commented Nov 5, 2025

Found several issues but will comment on those as part of #827

@felicio felicio changed the base branch from main to release/hub November 5, 2025 05:22
@felicio felicio changed the base branch from release/hub to main November 5, 2025 05:23
@felicio felicio merged commit f63ff3c into main Nov 5, 2025
12 of 13 checks passed
@github-project-automation github-project-automation bot moved this from Waiting to Done in Web & User Interfaces Nov 5, 2025
@felicio felicio mentioned this pull request Nov 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jkbktl jkbktl jkbktl approved these changes

@iamonuwa iamonuwa iamonuwa approved these changes

@jinhojang6 jinhojang6 Awaiting requested review from jinhojang6 jinhojang6 was automatically assigned from status-im/web

@JulesFiliot JulesFiliot Awaiting requested review from JulesFiliot JulesFiliot was automatically assigned from status-im/web

Assignees

@iamonuwa iamonuwa

Labels

None yet

Projects

Web & User Interfaces
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felicio @jkbktl @iamonuwa