Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add array/base/cuevery-by package #2831

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat: add array/base/cuevery-by package #2831

wants to merge 7 commits into from
+1,619 −0

Conversation

Kaif987
Copy link
Contributor

@Kaif987 Kaif987 commented Aug 24, 2024

This commit adds base/cuevery-by package

Resolves #2324

Description

What is the purpose of this pull request?
The purpose of this pull request is to add the @stdlib/base/cuevery-by package which cumulatively tests whether every array element in a provided array passes a test implemented by a predicate function.

Related Issues

Does this pull request have any related issues?
#2324

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Kaif987
feat(base): add base/cuevery-by package
ec9e373 
Ref: stdlib-js#2324

------------

Signed-off-by: Mohammad Kaif <[email protected]>
@Kaif987
fix: code style
39718f1
@Kaif987
fix(base): fix linting and styling errors
7679958 
This commit fixes all the eslint errors and styling error
that were introduced in previous commits

PR-URL: stdlib-js#2805
Ref: stdlib-js#649
---------
Signed-off-by: Mohammad Kaif <[email protected]>
@Kaif987
fix(base): fix repl.txt linting errors and revert changes made in cuany
b16c3fb 
This commit fixes linting errors made in repl.txt and
changes made in cuany are reverted.

PR-URL: stdlib-js#2805
Ref: stdlib-js#649
---------
Signed-off-by: Mohammad Kaif <[email protected]>
@Kaif987
Copy link
Contributor Author

Kaif987 commented Aug 25, 2024

Hey @kgryte can you review this? let me know if any further changes are needed,

@Kaif987
fix(base): fix typos and duplicate changes
53424ed 
This commit fixes any typos and duplicate function
definition in test files

PR-URL: stdlib-js#2805
Ref: stdlib-js#649
---------
Signed-off-by: Mohammad Kaif <[email protected]>
@Planeshifter Planeshifter self-requested a review September 7, 2024 16:03
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Sep 7, 2024
Planeshifter
Planeshifter requested changes Sep 7, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Left a few comments; PR looks good overall.

lib/node_modules/@stdlib/array/base/cuevery-by/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by/lib/index.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by/lib/index.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by/package.json Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by/README.md Show resolved Hide resolved
lib/node_modules/@stdlib/array/base/cuevery-by/docs/repl.txt Outdated Show resolved Hide resolved
@Kaif987
Copy link
Contributor Author

Kaif987 commented Sep 8, 2024

Hey @Planeshifter I just added the changes mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/array/base/cuevery-by
2 participants
@Kaif987 @Planeshifter