-
-
Notifications
You must be signed in to change notification settings - Fork 843
feat: add array/base/cuevery-by
package
#2831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ref: stdlib-js#2324 ------------ Signed-off-by: Mohammad Kaif <[email protected]>
This commit fixes all the eslint errors and styling error that were introduced in previous commits PR-URL: stdlib-js#2805 Ref: stdlib-js#649 --------- Signed-off-by: Mohammad Kaif <[email protected]>
This commit fixes linting errors made in repl.txt and changes made in cuany are reverted. PR-URL: stdlib-js#2805 Ref: stdlib-js#649 --------- Signed-off-by: Mohammad Kaif <[email protected]>
Hey @kgryte can you review this? let me know if any further changes are needed, |
This commit fixes any typos and duplicate function definition in test files PR-URL: stdlib-js#2805 Ref: stdlib-js#649 --------- Signed-off-by: Mohammad Kaif <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Left a few comments; PR looks good overall.
PR-URL: stdlib-js#2831 Ref: stdlib-js#2324 Co-authored-by: Mohammad Kaif <[email protected]>
Hey @Planeshifter I just added the changes mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Kaif987! Will merge shortly after CI has cleared.
This commit adds
base/cuevery-by
packageResolves #2324
Description
Related Issues
This pull request:
@stdlib/array/base/cuevery-by
#2324Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers