Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API and refactor blas/ext/base/dnannsumkbn #2988

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

feat: add C ndarray API and refactor blas/ext/base/dnannsumkbn #2988

wants to merge 16 commits into from

Conversation

headlessNode
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and refactor/cleanup blas/ext/base/dnannsumkbn

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Oct 5, 2024
@headlessNode
Copy link
Contributor Author

headlessNode commented Oct 5, 2024 •
edited
Loading

The failing test is from dnannsum which uses dnannsumkbn to compute the sum. It will be resolved once dnannsum is refactored.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Oct 5, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Oct 5, 2024
@headlessNode
Copy link
Contributor Author

headlessNode commented Oct 6, 2024 •
edited
Loading

@kgryte Using CBLAS_INT is causing the format specifier error. I think we will need to define format specifiers for CBLAS_INT.

EDIT: Just saw that it is defined. Sorry for the oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @kgryte @stdlib-bot