Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add constants/float32/ln-two #3079

Merged
merged 1 commit into from
Nov 9, 2024
Merged

feat: add constants/float32/ln-two #3079

merged 1 commit into from
Nov 9, 2024

Conversation

gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/ln-two, which would be the single-precision equivalent for constants/float64/ln-two.
  • unblocks the implementation of math/base/special/powf, which would be the single-precision equivalent for math/base/special/pow.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. labels Nov 9, 2024
Planeshifter
Planeshifter approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gunjjoshi!

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Nov 9, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `constants/float32/ln-two`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3079

Co-authored-by: 
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 893cb1b into stdlib-js:develop Nov 9, 2024
32 checks passed
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
@gunjjoshi @aayush0325
feat: add constants/float32/ln-two
87e3ecf 
PR-URL: stdlib-js#3079

Reviewed-by: Philipp Burckhardt <[email protected]>
@gunjjoshi gunjjoshi deleted the ln-two branch November 13, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @stdlib-bot @Planeshifter