feat: add support for computing the derivative of cardinal sine (cosc)

[RiyaChy072]

Resolves #224

Description

What is the purpose of this pull request?

This pull request:

• added support for #[RFC]: add support for computing the derivative of cardinal sine (cosc) [RFC]: add support for computing the derivative of cardinal sine (cosc) #224

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves #[RFC]: add support for computing the derivative of cardinal sine (cosc) [RFC]: add support for computing the derivative of cardinal sine (cosc) #224

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

[RiyaChy072]

@kgryte Can you please check if it's done? Thank you

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/cosc	$\color{green}196/196$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}196/196$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[AbhijitRaut04]

Took them from SINC and added some changes

I think you didn't changed the expected values by running your cosc function for each of x values. That should be the reason for failing tests.

[RiyaChy072]

@AbhijitRaut04 I just calculated some of the values and changed them accordingly. Should i run the cosc function locally and then get the values? Actually I'm just a beginner, that's why facing many issues and unable to perfectly execute

[AbhijitRaut04]

@AbhijitRaut04 I just calculated some of the values and changed them accordingly. Should i run the cosc function locally and then get the values? Actually I'm just a beginner, that's why facing many issues and unable to perfectly execute

You can get expected values by running a for loop in another file (which will not contribute to PR) by writing code suggested in Readme.md file. Then you can run cosc( x ) and get the particular expected values by consoling and you can copy them.

[RiyaChy072]

@AbhijitRaut04 Did what you suggested. The values were same. I mentioned with 3values after decimal point, but maybe the result wasn't coming with many 3values after decimal point. So i added .toFixed(3) for getting the same value as expected. Still the run_tests_coverage failed. What do you think i should do now?

[AbhijitRaut04]

Change expected values here. And other fixtures also.

[AbhijitRaut04]

@RiyaChy072 I have suggested to change fixture expected values for each value of x .

[AbhijitRaut04]

Here is example of secant function.

[RiyaChy072]

@AbhijitRaut04 Still getting error :(

[AbhijitRaut04]

@RiyaChy072
The difference between the expected value and computed value needs to be 0.0.
@kgryte What needs to be done to overcome this ?

[RiyaChy072]

@AbhijitRaut04 Maybe i did something wrong. Trying to fix this and will update soon

[RiyaChy072]

@kgryte CI activity has been passed

[RiyaChy072]

@AbhijitRaut04 Thanks for your guidance. CI activity has been passed

[gunjjoshi]

@RiyaChy072 Thanks for working on this. Some of the CI checks are failing. Can you please update this PR accordingly?

[RiyaChy072]

@gunjjoshi Is it done now?

[RiyaChy072]

@gunjjoshi Can you please tell me if i have anything left to do?