feat: add `math/base/special/minmaxf` #7039

anandkaranubc · 2025-05-19T19:57:38Z

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

Adds the complete C implementation for math/base/special/minmaxf

Related Issues

Does this pull request have any related issues?

This pull request:

Progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

anandkaranubc · 2025-05-19T19:58:50Z

/stdlib update-copyright-years

stdlib-bot · 2025-05-19T19:59:39Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/minmaxf	$\color{green}253/253$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}253/253$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Planeshifter

LGTM!

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

anandkaranubc · 2025-05-20T01:47:51Z

Sorry, did some more clean-up to ensure consistency with other similar implementations.

Should be ready to merge.

Signed-off-by: Karan Anand <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/math/base/special/minmaxf/docs/types/index.d.ts

lib/node_modules/@stdlib/math/base/special/minmaxf/docs/types/test.ts

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter

LGTM!

stdlib-bot · 2025-06-13T22:03:10Z

PR Commit Message

feat: add `math/base/special/minmaxf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/7039
Ref: https://github.com/stdlib-js/stdlib/issues/649

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Karan Anand <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

feat: add C implementation for math/base/special/minmaxf

6374f1d

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels May 19, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label May 19, 2025

chore: update copyright years

3767801

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label May 19, 2025

anandkaranubc added 4 commits May 19, 2025 13:25

Planeshifter previously approved these changes May 19, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 19, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label May 19, 2025

anandkaranubc mentioned this pull request May 19, 2025

feat: add math/base/special/minmaxf #3390

Closed

1 task

anandkaranubc added 2 commits May 19, 2025 16:09

anandkaranubc dismissed Planeshifter’s stale review via e144ece May 19, 2025 23:11

anandkaranubc added GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels May 20, 2025

anandkaranubc and others added 3 commits May 26, 2025 11:36

Update benchmark.native.js

0915533

Signed-off-by: Karan Anand <[email protected]>

Merge branch 'develop' into feat/minmaxf

f7f992f

Planeshifter reviewed Jun 13, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/minmaxf/docs/types/index.d.ts Outdated Show resolved Hide resolved

Planeshifter reviewed Jun 13, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/minmaxf/docs/types/test.ts Outdated Show resolved Hide resolved

refactor: use tuple for return type

038529a

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter approved these changes Jun 13, 2025

View reviewed changes

Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Ready To Merge A pull request which is ready to be merged. labels Jun 13, 2025

Planeshifter merged commit 5625d06 into stdlib-js:develop Jun 13, 2025
29 checks passed

anandkaranubc deleted the feat/minmaxf branch June 14, 2025 06:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `math/base/special/minmaxf` #7039

feat: add `math/base/special/minmaxf` #7039

Uh oh!

anandkaranubc commented May 19, 2025

Uh oh!

anandkaranubc commented May 19, 2025

Uh oh!

stdlib-bot commented May 19, 2025 •

edited

Loading

Uh oh!

Planeshifter left a comment

Uh oh!

anandkaranubc commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Jun 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: add math/base/special/minmaxf #7039

feat: add math/base/special/minmaxf #7039

Uh oh!

Conversation

anandkaranubc commented May 19, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

anandkaranubc commented May 19, 2025

Uh oh!

stdlib-bot commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

anandkaranubc commented May 20, 2025

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jun 13, 2025

PR Commit Message

Uh oh!

Uh oh!

Uh oh!

feat: add `math/base/special/minmaxf` #7039

feat: add `math/base/special/minmaxf` #7039

stdlib-bot commented May 19, 2025 •

edited

Loading