Skip to content

feat: add assert/has-float16array-support #7347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 8, 2025
Merged

feat: add assert/has-float16array-support #7347

merged 14 commits into from
Jul 8, 2025

Conversation

udaykakade25
Copy link
Contributor

@udaykakade25 udaykakade25 commented Jun 13, 2025 •
edited by kgryte
Loading

Description

What is the purpose of this pull request?

This pull request:

  • Adds assert/has-float16array-support

Related Issues

Does this pull request have any related issues?

This pull request:

  • adds support for detecting Float16Array support.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

This is the second PR (apart from the first PR: assert/is-float16array) that adds support for float16 arrays, requiring the creation of an array/float16. The first PR ( #7273 ) should be merged first, as this PR requires some functionality from the previous PR.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jun 13, 2025
@udaykakade25
Copy link
Contributor Author

Hello @Planeshifter and @kgryte sir,
This is the second PR that requires the first PR (#7273) to be merged, as some functionalities are taken from it.
Almost every code file is running perfectly after skipping test cases requiring float16.
Please do review this PR!

@udaykakade25 udaykakade25 mentioned this pull request Jun 21, 2025
Open
1 task
@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Jun 22, 2025
@kgryte
Copy link
Member

kgryte commented Jul 8, 2025

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 8, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 8, 2025
@kgryte
Copy link
Member

kgryte commented Jul 8, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 8, 2025
@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Potential Duplicate There might be another pull request resolving the same issue. labels Jul 8, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 8, 2025
kgryte
kgryte reviewed Jul 8, 2025
View reviewed changes
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jul 8, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
assert/has-float16array-support $\color{green}133/133$
$\color{green}+100.00\%$ 		$\color{red}11/12$
$\color{green}+91.67\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}133/133$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte reviewed Jul 8, 2025
View reviewed changes
@kgryte
docs: add TODO
f719362 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Jul 8, 2025
View reviewed changes
@kgryte
chore: fix keyword
c329c07 
Signed-off-by: Athan <[email protected]>
@kgryte
Copy link
Member

kgryte commented Jul 8, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 8, 2025
@kgryte kgryte self-requested a review July 8, 2025 08:16
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 8, 2025
@kgryte
chore: resolve style issues and clean-up
96450a2 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 8, 2025
@kgryte
test: fix test case
fe9d362 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
kgryte
kgryte previously approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte
style: disable lint rule
154bad3 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
kgryte
kgryte previously approved these changes Jul 8, 2025
View reviewed changes
@kgryte
fix: resolve failing tests
98a7f4e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte merged commit e6e4501 into stdlib-js:develop Jul 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@udaykakade25 @kgryte @stdlib-bot