Skip to content

feat: add stats/strided/ztest2 #7464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: add stats/strided/ztest2 #7464

wants to merge 6 commits into from

Conversation

gururaj1512
Copy link
Member

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • feat: add stats/strided/ztest2

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Jun 23, 2025
@gururaj1512 gururaj1512 added GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels Jun 23, 2025
@gururaj1512 gururaj1512 mentioned this pull request Jun 23, 2025
Open
@gururaj1512
Copy link
Member Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 1, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 1, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jul 1, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/strided/ztest2 $\color{green}297/297$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}297/297$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@gururaj1512
Copy link
Member Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jul 3, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jul 3, 2025
@gururaj1512 gururaj1512 marked this pull request as ready for review July 3, 2025 19:55
@gururaj1512 gururaj1512 marked this pull request as draft July 3, 2025 19:55
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jul 3, 2025
@gururaj1512 gururaj1512 marked this pull request as ready for review July 4, 2025 09:55
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 4, 2025
@gururaj1512
fix: update ztest2 function call
a5ea81b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
gururaj1512
gururaj1512 commented Jul 4, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/strided/ztest2/README.md Outdated

- As a general rule of thumb, a Z-test is most reliable when `N >= 50`. For smaller sample sizes or when the standard deviation is unknown, prefer a t-test.
- Both functions support array-like objects having getter and setter accessors for array element access (e.g., [`@stdlib/array/base/accessor`][@stdlib/array/base/accessor]).
- Depending on the environment, the typed versions ([`dztest2`][@stdlib/stats/strided/dztest2], [`sztest2`][@stdlib/stats/strided/sztest2], etc.) are likely to be significantly more performant.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packages not yet added...!

kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte reviewed Jul 5, 2025
View reviewed changes
kgryte
kgryte requested changes Jul 5, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jul 5, 2025
@kgryte kgryte added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jul 9, 2025
kgryte
kgryte reviewed Jul 10, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/strided/ztest2/README.md
var ztest2 = require( '@stdlib/stats/strided/ztest2' );
```

#### ztest2( NX, NY, alternative, alpha, diff, sigmax, sigmay, x, strideX, y, strideY, out )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gururaj1512 After reviewing other binary array packages, I think you were right. We should update the signatures such that sigmay is near y.

ztest2( NX, NY, alternative, alpha, diff, sigmax, x, strideX, sigmay, y, strideY, out )

I am working on a PoC for computing the covariance, and, there, I plan on doing

covm( N, correction, meanx, x, strideX, meany, y, strideY )

In which case, we should be consistent across our APIs. Would you be willing to refactor this package accordingly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gururaj1512 @stdlib-bot @kgryte