feat: add `blas/ext/base/drsskbn` #9013

nakul-krishnakumar · 2025-12-12T19:30:10Z

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: passed
task: lint_c_examples status: passed
task: lint_c_benchmarks status: passed
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

Adds blas/ext/base/drsskbn.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

None.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

stdlib-bot · 2025-12-12T19:32:20Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/drsskbn	$\color{green}409/409$ $\color{green}+0.00%$	$\color{green}19/19$ $\color{green}+0.00%$	$\color{green}4/4$ $\color{green}+0.00%$	$\color{green}409/409$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

lib/node_modules/@stdlib/blas/ext/base/drsskbn/benchmark/c/benchmark.length.c

Signed-off-by: Nakul Krishnakumar <[email protected]>

…hmark name --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

kgryte · 2025-12-27T09:32:26Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/README.md

+<!-- <equation class="equation" label="eq:residual_sum_of_squares" align="center" raw="d = \sum_{i=0}^{N-1} (y_i - x_i)^2" alt="Equation for residual sum of squares."> -->
+
+```math
+\mathop{\mathrm{RSS}} = \sum_{i=0}^{n-1} (y_i - x_i)^2


Suggested change

\mathop{\mathrm{RSS}} = \sum_{i=0}^{n-1} (y_i - x_i)^2

\mathop{\mathrm{RSS}} = \sum_{i=0}^{N-1} (y_i - x_i)^2

kgryte · 2025-12-27T09:33:13Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/docs/types/index.d.ts

+	* var y = new Float64Array( [ 2.0, 1.0, 2.0, 1.0, -2.0, 2.0, 3.0, 4.0 ] );
+	*
+	* var z = drsskbn( x.length, x, 1, y, 1 );
+	* // returns 72


Same comment regarding decimals.

kgryte · 2025-12-27T09:33:44Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/benchmark/c/benchmark.length.c

+	elapsed = tic() - t;
+	if ( v != v ) {
+		printf( "should not return NaN\n" );
+	}


You need to free allocated memory.

kgryte · 2025-12-27T09:33:56Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/benchmark/c/benchmark.length.c

+	elapsed = tic() - t;
+	if ( v != v ) {
+		printf( "should not return NaN\n" );
+	}


You need to free allocated memory.

kgryte

I am guessing that some of the same comments made in #8722 also apply here.

lib/node_modules/@stdlib/blas/ext/base/drsskbn/test/test.drsskbn.js

lib/node_modules/@stdlib/blas/ext/base/drsskbn/test/test.drsskbn.native.js

lib/node_modules/@stdlib/blas/ext/base/drsskbn/test/test.ndarray.js

lib/node_modules/@stdlib/blas/ext/base/drsskbn/test/test.ndarray.native.js

Signed-off-by: Nakul Krishnakumar <[email protected]>

lib/node_modules/@stdlib/blas/ext/base/drsskbn/test/test.drsskbn.js

lib/node_modules/@stdlib/blas/ext/base/drsskbn/test/test.drsskbn.native.js

lib/node_modules/@stdlib/blas/ext/base/drsskbn/test/test.ndarray.js

lib/node_modules/@stdlib/blas/ext/base/drsskbn/test/test.ndarray.native.js

Signed-off-by: Nakul Krishnakumar <[email protected]>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/blas/ext/base/drsskbn/benchmark/benchmark.js

lib/node_modules/@stdlib/blas/ext/base/drsskbn/benchmark/benchmark.native.js

lib/node_modules/@stdlib/blas/ext/base/drsskbn/benchmark/benchmark.ndarray.js

lib/node_modules/@stdlib/blas/ext/base/drsskbn/benchmark/benchmark.ndarray.native.js

Signed-off-by: Nakul Krishnakumar <[email protected]>

kgryte · 2026-01-10T11:00:54Z

/stdlib merge

…sskbn

kgryte · 2026-01-10T11:19:03Z

@nakul-krishnakumar Lint failures.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

nakul-krishnakumar · 2026-01-10T13:07:37Z

@kgryte This PR is ready for review.

Planeshifter · 2026-01-11T06:46:35Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/lib/drsskbn.js

+// MODULES //
+
+var stride2offset = require( '@stdlib/strided/base/stride2offset' );
+var ndarray = require( './../lib/ndarray.js' );


The path ./../lib/ndarray.js is incorrect since this file is already in the lib/ directory.

Suggested change

var ndarray = require( './../lib/ndarray.js' );

var ndarray = require( './ndarray.js' );

Planeshifter · 2026-01-11T06:46:36Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/lib/ndarray.js

+// MAIN //
+
+/**
+* Computes the residual sum of squares of two double-precision floating-point strided arrays using using an improved Kahan–Babuška algorithm.


There's a duplicate "using" here.

Suggested change

* Computes the residual sum of squares of two double-precision floating-point strided arrays using using an improved Kahan–Babuška algorithm.

* Computes the residual sum of squares of two double-precision floating-point strided arrays using an improved Kahan–Babuška algorithm.

Planeshifter · 2026-01-11T06:46:38Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/README.md

+
+#### drsskbn.ndarray( N, x, strideX, offsetX,  y, strideY, offsetY )
+
+Computes the [residual sum of squares][wikipedia-residual-sum-of-squares] of two double-precision floating-point strided arrays an improved Kahan–Babuška algorithm and alternative indexing semantics.


Missing word "using" - should be "...strided arrays using an improved..."

Suggested change

Computes the [residual sum of squares][wikipedia-residual-sum-of-squares] of two double-precision floating-point strided arrays an improved Kahan–Babuška algorithm and alternative indexing semantics.

Computes the [residual sum of squares][wikipedia-residual-sum-of-squares] of two double-precision floating-point strided arrays using an improved Kahan–Babuška algorithm and alternative indexing semantics.

Planeshifter · 2026-01-11T06:46:39Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/README.md

+
+<!--lint enable maximum-heading-length-->
+
+Computes the [residual sum of squares][wikipedia-residual-sum-of-squares] of two double-precision floating-point strided arrays an improved Kahan–Babuška algorithm and alternative indexing semantics.


Same issue here - missing word "using".

Suggested change

Computes the [residual sum of squares][wikipedia-residual-sum-of-squares] of two double-precision floating-point strided arrays an improved Kahan–Babuška algorithm and alternative indexing semantics.

Computes the [residual sum of squares][wikipedia-residual-sum-of-squares] of two double-precision floating-point strided arrays using an improved Kahan–Babuška algorithm and alternative indexing semantics.

Planeshifter · 2026-01-11T06:46:40Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/README.md

+const double x[] = { 1.0, -2.0, 2.0 };
+const double y[] = { 1.0, 1.0, -4.0 };
+
+double v = stdlib_strided_drsskbn_ndarray( 3, x, 1, 0, 1, 0 );


This function call is missing the y array parameter. According to the function signature on line 256, it should have 7 arguments: N, X, strideX, offsetX, Y, strideY, offsetY.

Suggested change

double v = stdlib_strided_drsskbn_ndarray( 3, x, 1, 0, 1, 0 );

double v = stdlib_strided_drsskbn_ndarray( 3, x, 1, 0, y, 1, 0 );

Planeshifter · 2026-01-11T06:47:21Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/src/main.c

+* @param strideY      stride length of `Y`
+* @return             output value
+*/
+double API_SUFFIX( stdlib_strided_drsskbn )( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const double *Y, const CBLAS_INT strideY ) {


Same API_SUFFIX spacing issue throughout this file - should be API_SUFFIX(stdlib_strided_drsskbn) without the space after the opening paren.

Suggested change

double API_SUFFIX( stdlib_strided_drsskbn )( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const double *Y, const CBLAS_INT strideY ) {

double API_SUFFIX(stdlib_strided_drsskbn)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const double *Y, const CBLAS_INT strideY ) {

Planeshifter · 2026-01-11T06:47:22Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/src/main.c

+double API_SUFFIX( stdlib_strided_drsskbn )( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const double *Y, const CBLAS_INT strideY ) {
+	const CBLAS_INT ox = stdlib_strided_stride2offset( N, strideX );
+	const CBLAS_INT oy = stdlib_strided_stride2offset( N, strideY );
+	return API_SUFFIX( stdlib_strided_drsskbn_ndarray )( N, X, strideX, ox, Y, strideY, oy );


Suggested change

return API_SUFFIX( stdlib_strided_drsskbn_ndarray )( N, X, strideX, ox, Y, strideY, oy );

return API_SUFFIX(stdlib_strided_drsskbn_ndarray)( N, X, strideX, ox, Y, strideY, oy );

Planeshifter · 2026-01-11T06:47:23Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/src/main.c

+* @param offsetY      starting index for `Y`
+* @return             output value
+*/
+double API_SUFFIX( stdlib_strided_drsskbn_ndarray )( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, const double *Y, const CBLAS_INT strideY, const CBLAS_INT offsetY ) {


Suggested change

double API_SUFFIX( stdlib_strided_drsskbn_ndarray )( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, const double *Y, const CBLAS_INT strideY, const CBLAS_INT offsetY ) {

double API_SUFFIX(stdlib_strided_drsskbn_ndarray)( const CBLAS_INT N, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, const double *Y, const CBLAS_INT strideY, const CBLAS_INT offsetY ) {

Planeshifter · 2026-01-11T06:47:24Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/src/addon.c

+	STDLIB_NAPI_ARGV_INT64( env, strideY, argv, 4 );
+	STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 );
+	STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, Y, N, strideY, argv, 3 );
+	STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX( stdlib_strided_drsskbn )( N, X, strideX, Y, strideY ), v );


Same API_SUFFIX spacing issue.

Suggested change

STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX( stdlib_strided_drsskbn )( N, X, strideX, Y, strideY ), v );

STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX(stdlib_strided_drsskbn)( N, X, strideX, Y, strideY ), v );

Planeshifter · 2026-01-11T06:47:25Z

lib/node_modules/@stdlib/blas/ext/base/drsskbn/src/addon.c

+	STDLIB_NAPI_ARGV_INT64( env, offsetY, argv, 6 );
+	STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 );
+	STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, Y, N, strideY, argv, 4 );
+	STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX( stdlib_strided_drsskbn_ndarray )( N, X, strideX, offsetX, Y, strideY, offsetY ), v );


Suggested change

STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX( stdlib_strided_drsskbn_ndarray )( N, X, strideX, offsetX, Y, strideY, offsetY ), v );

STDLIB_NAPI_CREATE_DOUBLE( env, API_SUFFIX(stdlib_strided_drsskbn_ndarray)( N, X, strideX, offsetX, Y, strideY, offsetY ), v );

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 12, 2025

kgryte added the Feature Issue or pull request for adding a new feature. label Dec 16, 2025

nakul-krishnakumar commented Dec 16, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/drsskbn/benchmark/c/benchmark.length.c Outdated Show resolved Hide resolved

nakul-krishnakumar added 2 commits December 16, 2025 14:07

chore: update according to code review

0958a83

Signed-off-by: Nakul Krishnakumar <[email protected]>

kgryte reviewed Dec 27, 2025

View reviewed changes

kgryte requested changes Dec 27, 2025

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 27, 2025