feat: add `blas/ext/base/drssors` #9086

nakul-krishnakumar · 2025-12-16T11:12:42Z

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

Adds blas/ext/base/drssors.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

None.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

…hmark name --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-12-16T11:14:53Z

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/drssors	$\color{red}393/404$ $\color{green}+0.00%$	$\color{red}19/23$ $\color{green}+0.00%$	$\color{green}4/4$ $\color{green}+0.00%$	$\color{red}393/404$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

lib/node_modules/@stdlib/blas/ext/base/drssors/test/test.drssors.js

lib/node_modules/@stdlib/blas/ext/base/drssors/test/test.drssors.native.js

lib/node_modules/@stdlib/blas/ext/base/drssors/test/test.ndarray.js

lib/node_modules/@stdlib/blas/ext/base/drssors/test/test.ndarray.native.js

Signed-off-by: Nakul Krishnakumar <[email protected]>

kgryte · 2025-12-27T08:18:43Z

lib/node_modules/@stdlib/blas/ext/base/drssors/README.md

+
+# drssors
+
+> Calculate the [residual sum of squares][wikipedia-residual-sum-of-squares] of two double-precision floating-point strided arrays, ignoring `NaN` values and using an ordinary recursive summation.


@nakul-krishnakumar If this package is supposed to ignore NaN values, it is misnamed. It should be dnanrssors. For drssors, we shouldn't have any special NaN handling.

Accordingly, in order to avoid unnecessary work, I suggest simply renaming this package (and all aliases) from drssors to dnanrssors.

kgryte · 2025-12-27T08:25:38Z

lib/node_modules/@stdlib/blas/ext/base/drssors/test/test.drssors.js

+	y = new Float64Array( [ -1.0e-15, -1.0e-15, -1.0e-15, -1.0e-15 ] );
+
+	z = drssors( x.length, x, 1, y, 1 );
+	t.strictEqual( z, 1.6e-29, 'returns expected value' );


These expected values were computed how? Did you test against a reference implementation? Calculate by hand? Something else?

In general, we prefer avoiding magic numbers in test cases. For example, if computed by hand, one might add a comment like

// Test against textbook formula: ( (1+1) + (1+1) + (1+1) + (1+1) )^2 * (10^-15)^2

Otherwise, future readers are liable to simply assume that you either made the numbers up or you simply performed a circular test (i.e., the "expected" value is computed the implementation you are wanting to test). TL;DR: test cases should be generated independently of the implementation, and, where possible, we should document how they were computed, if it is not immediately obvious or the implementation cannot be inlined.

@kgryte These were actually calculated using a reference implementation, from next time I will make sure to properly document the computation. Thank you for the suggestion :)

kgryte · 2025-12-27T08:27:34Z

lib/node_modules/@stdlib/blas/ext/base/drssors/test/test.drssors.js

+	var y;
+	var z;
+
+	x = new Float64Array( [ 1.0, -2.0, -4.0, 5.0, 0.0, 3.0 ] );


Your implementation is designed to ignore NaN values, and yet your tests do not test for this behavior at all. They all contain only non-NaN values. You should study stats/strided for how we test against nan* and non-nan variants.

kgryte

Left initial comments.

lib/node_modules/@stdlib/blas/ext/base/drssors/benchmark/benchmark.js

lib/node_modules/@stdlib/blas/ext/base/drssors/benchmark/benchmark.native.js

lib/node_modules/@stdlib/blas/ext/base/drssors/benchmark/benchmark.ndarray.js

lib/node_modules/@stdlib/blas/ext/base/drssors/benchmark/benchmark.ndarray.native.js

Signed-off-by: Nakul Krishnakumar <[email protected]>

nakul-krishnakumar · 2026-01-10T09:33:34Z

/stdlib update-copyright-years

stdlib-bot · 2026-01-10T09:35:16Z

/stdlib update-copyright-years

@nakul-krishnakumar, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

kgryte · 2026-01-10T11:01:14Z

/stdlib merge

…ssors

kgryte · 2026-01-10T11:19:12Z

@nakul-krishnakumar Lint failures.

nakul-krishnakumar · 2026-01-10T12:36:42Z

This PR is WIP.

nakul-krishnakumar added 2 commits December 16, 2025 14:16

stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Dec 16, 2025

kgryte added the Feature Issue or pull request for adding a new feature. label Dec 16, 2025

nakul-krishnakumar commented Dec 25, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/drssors/test/test.drssors.js Outdated Show resolved Hide resolved

nakul-krishnakumar commented Dec 25, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/drssors/test/test.drssors.native.js Outdated Show resolved Hide resolved

nakul-krishnakumar commented Dec 25, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/drssors/test/test.ndarray.js Outdated Show resolved Hide resolved

nakul-krishnakumar commented Dec 25, 2025

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/drssors/test/test.ndarray.native.js Outdated Show resolved Hide resolved

chore: update according to code review

0a9a9c4

Signed-off-by: Nakul Krishnakumar <[email protected]>

kgryte removed the Needs Review A pull request which needs code review. label Dec 27, 2025

kgryte reviewed Dec 27, 2025

View reviewed changes

kgryte requested changes Dec 27, 2025

View reviewed changes

kgryte added the Needs Changes Pull request which needs changes before being merged. label Dec 27, 2025

nakul-krishnakumar commented Jan 10, 2026

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/drssors/benchmark/benchmark.js Show resolved Hide resolved

nakul-krishnakumar commented Jan 10, 2026

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/drssors/benchmark/benchmark.native.js Outdated Show resolved Hide resolved

nakul-krishnakumar commented Jan 10, 2026

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/drssors/benchmark/benchmark.ndarray.js Outdated Show resolved Hide resolved

nakul-krishnakumar commented Jan 10, 2026

View reviewed changes

lib/node_modules/@stdlib/blas/ext/base/drssors/benchmark/benchmark.ndarray.native.js Outdated Show resolved Hide resolved

bench: add JSDoc to missing benchmark functions

ca092b4

Signed-off-by: Nakul Krishnakumar <[email protected]>

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 10, 2026

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 10, 2026

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 10, 2026

kgryte added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jan 10, 2026

Merge remote-tracking branch 'upstream/develop' into blas-ext-base-dr…

83ec62f

…ssors

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 10, 2026

kgryte added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label Jan 10, 2026

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels Jan 10, 2026

chore: update copyright years

12df0fe

nakul-krishnakumar marked this pull request as draft January 10, 2026 12:36

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 10, 2026


		# drssors

		> Calculate the [residual sum of squares][wikipedia-residual-sum-of-squares] of two double-precision floating-point strided arrays, ignoring `NaN` values and using an ordinary recursive summation.

Uh oh!

feat: add blas/ext/base/drssors #9086

Are you sure you want to change the base?

feat: add blas/ext/base/drssors #9086

Conversation

nakul-krishnakumar commented Dec 16, 2025

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

nakul-krishnakumar Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nakul-krishnakumar commented Jan 10, 2026

Uh oh!

stdlib-bot commented Jan 10, 2026

Uh oh!

kgryte commented Jan 10, 2026

Uh oh!

kgryte commented Jan 10, 2026

Uh oh!

nakul-krishnakumar commented Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `blas/ext/base/drssors` #9086

feat: add `blas/ext/base/drssors` #9086

stdlib-bot commented Dec 16, 2025 •

edited

Loading