Skip to content

Conversation

@KovidhRaj
Copy link
Contributor

@KovidhRaj KovidhRaj commented Jan 3, 2026

…ed-array


type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 3, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 3, 2026

Coverage Report

Package Statements Branches Functions Lines
array/base/assert/is-complex-typed-array $\color{green}109/109$
$\color{green}+0.00%$
$\color{green}8/8$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}109/109$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the desired change, as we do not use template strings; see other merged PRs of this nature for what is expected.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jan 5, 2026
@KovidhRaj
Copy link
Contributor Author

@Planeshifter Ok....i am on it. Thanks for your insights

@KovidhRaj KovidhRaj force-pushed the bench-is-complex-typed-array branch from 4c9b82b to 96ab490 Compare January 5, 2026 10:33
@KovidhRaj
Copy link
Contributor Author

I’ve removed template literals and updated the code to follow existing stdlib conventions.

@KovidhRaj KovidhRaj requested a review from Planeshifter January 6, 2026 03:52
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 6, 2026
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. Look at the lint warning that tells you what is expected ("Use @stdlib/string/format instead of string concatenation for benchmark descriptions") or consult merged PRs of this type, as you clearly haven't done.

@KovidhRaj
Copy link
Contributor Author

Ok on it

@KovidhRaj KovidhRaj force-pushed the bench-is-complex-typed-array branch from 96ab490 to bdba9bb Compare January 6, 2026 04:34
@KovidhRaj
Copy link
Contributor Author

Thanks for the clarification. I’ve updated the benchmark to replace string concatenation with @stdlib/string/format, following the RFC instructions.

…ed-array

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@KovidhRaj KovidhRaj force-pushed the bench-is-complex-typed-array branch from bdba9bb to 567cec7 Compare January 6, 2026 10:36
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks! Will merge shortly.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks! Will merge shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 6, 2026
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Jan 6, 2026
@stdlib-bot
Copy link
Contributor

PR Commit Message

bench: use string interpolation for benchmark names in is-complex-typ…

PR-URL: https://github.com/stdlib-js/stdlib/pull/9517

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit ff76be4 into stdlib-js:develop Jan 6, 2026
31 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jan 6, 2026
@KovidhRaj
Copy link
Contributor Author

thank you and it was a good learning for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants