-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
bench: use string interpolation for benchmark names in is-complex-typ… #9517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: use string interpolation for benchmark names in is-complex-typ… #9517
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the desired change, as we do not use template strings; see other merged PRs of this nature for what is expected.
|
@Planeshifter Ok....i am on it. Thanks for your insights |
4c9b82b to
96ab490
Compare
|
I’ve removed template literals and updated the code to follow existing stdlib conventions. |
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. Look at the lint warning that tells you what is expected ("Use @stdlib/string/format instead of string concatenation for benchmark descriptions") or consult merged PRs of this type, as you clearly haven't done.
|
Ok on it |
96ab490 to
bdba9bb
Compare
|
Thanks for the clarification. I’ve updated the benchmark to replace string concatenation with @stdlib/string/format, following the RFC instructions. |
…ed-array
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
bdba9bb to
567cec7
Compare
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks! Will merge shortly.
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks! Will merge shortly.
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
|
thank you and it was a good learning for me |
…ed-array
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves #{{TODO: add issue number}}.
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers