Conversation
…sh-fix # Conflicts: # Sources/CodexBarCore/KeychainAccessGate.swift # Tests/CodexBarTests/ClaudeOAuthCredentialsStoreTests.swift # Tests/CodexBarTests/ClaudeOAuthKeychainAccessGateTests.swift # Tests/CodexBarTests/KimiProviderTests.swift
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b254d0e0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sources/CodexBarCore/Providers/Claude/ClaudeOAuth/ClaudeOAuthCredentials.swift
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa42272d2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sources/CodexBarCore/Providers/Claude/ClaudeOAuth/ClaudeOAuthCredentials.swift
Show resolved
Hide resolved
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Problem
CodexBar refreshed Claude OAuth using the refresh token read from the macOS Keychain item
Claude Code-credentials. If the server rotates refresh tokens, CodexBar updated only its own cache, leaving Claude CLI holding an invalid refresh token and later hitting 401 / forced re-login.Fix
claude(no direct token-endpoint refresh for Claude-owned creds).Notes
Claude Code-credentialscan still trigger Keychain UI even after “Always Allow”, so OAuth-on-expiry may remain prompty.Verification
swift testpnpm check./Scripts/compile_and_run.sh