fix(mac): avoid persisting settings while loading#86
Merged
steipete merged 2 commits intosteipete:mainfrom Mar 13, 2026
Merged
Conversation
steipete
force-pushed
the
upstream-fix-settings-load-safety
branch
from
ed5de6e to
3e13e90
Compare
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80.
Prevents the macOS settings object from saving UserDefaults, credentials, or config.json while it is still hydrating from config-backed provider state. That avoids the launch-time partial write that was resetting unrelated UI settings and rewriting an existing config file.
I also added a regression test for config-backed init preserving both the existing config and unrelated UI defaults. Built
Apps/Maclocally. The current Mac package test target still has unrelated upstream compile failures inEndToEndTestsandStatusBarControllerTests, so the new test is included in the package but that target does not fully run clean onmaintoday.