Skip to content

feat(drive): add commenter role to drive share #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavelzak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(drive): add commenter role to drive share #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions internal/cmd/drive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,11 @@ const (
driveShareToUser = "user"
driveShareToDomain = "domain"

drivePermRoleReader = "reader"
drivePermRoleWriter = "writer"
// Drive sharing permission roles matching the Google Drive API roles.
// "commenter" allows view + comment access without edit rights.
drivePermRoleReader = "reader"
drivePermRoleWriter = "writer"
drivePermRoleCommenter = "commenter"
)

type DriveCmd struct {
Expand Down Expand Up @@ -719,7 +722,7 @@ type DriveShareCmd struct {
Anyone bool `name:"anyone" hidden:"" help:"(deprecated) Use --to=anyone"`
Email string `name:"email" help:"User email (for --to=user)"`
Domain string `name:"domain" help:"Domain (for --to=domain; e.g. example.com)"`
Role string `name:"role" help:"Permission: reader|writer" default:"reader"`
Role string `name:"role" help:"Permission: reader|writer|commenter" default:"reader"`
Discoverable bool `name:"discoverable" help:"Allow file discovery in search (anyone/domain only)"`
}

Expand Down Expand Up @@ -785,8 +788,8 @@ func (c *DriveShareCmd) Run(ctx context.Context, flags *RootFlags) error {
if role == "" {
role = drivePermRoleReader
}
if role != drivePermRoleReader && role != drivePermRoleWriter {
return usage("invalid --role (expected reader|writer)")
if role != drivePermRoleReader && role != drivePermRoleWriter && role != drivePermRoleCommenter {
return usage("invalid --role (expected reader|writer|commenter)")
}

svc, err := newDriveService(ctx, account)
Expand Down