Skip to content

fix(daemon): skip Bun virtual entry path in detached child spawn #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dedene wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

fix(daemon): skip Bun virtual entry path in detached child spawn #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/daemon/launch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function launchDaemonDetached(options: DaemonLaunchOptions): void {
const configArgs = options.configExplicit ? ['--config', options.configPath] : [];
const args = [
...process.execArgv,
cliEntry,
...(cliEntry ? [cliEntry] : []),
...configArgs,
...(options.rootDir ? ['--root', options.rootDir] : []),
'daemon',
Expand All @@ -36,10 +36,16 @@ export function launchDaemonDetached(options: DaemonLaunchOptions): void {
child.unref();
}

function resolveCliEntry(): string {
function resolveCliEntry(): string | undefined {
const entry = process.argv[1];
if (!entry) {
throw new Error('Unable to resolve mcporter entry script.');
}
// In Bun compiled binaries, argv[1] is a virtual /$bunfs/... path that Bun
// auto-injects into every spawned child. Including it explicitly would
// duplicate it and break CLI argument parsing in the child process.
if (entry.startsWith('/$bunfs/')) {
return undefined;
}
return path.resolve(entry);
}