Skip to content

fix: parse object-type parameters as JSON in generated CLIs #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
v2nic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: parse object-type parameters as JSON in generated CLIs #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/cli/generate/template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,8 @@ function optionParser(option: GeneratedOption): string | undefined {
return '(value) => parseFloat(value)';
case 'boolean':
return "(value) => value !== 'false'";
case 'object':
return '(value) => JSON.parse(value)';
case 'array':
// Coerce array elements to their proper types based on schema
switch (option.arrayItemType) {
Expand Down
4 changes: 2 additions & 2 deletions src/cli/generate/tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export interface GeneratedOption {
cliName: string;
description?: string;
required: boolean;
type: 'string' | 'number' | 'boolean' | 'array' | 'unknown';
type: 'string' | 'number' | 'boolean' | 'array' | 'object' | 'unknown';
arrayItemType?: 'string' | 'number' | 'boolean' | 'unknown';
placeholder: string;
exampleValue?: string;
Expand Down Expand Up @@ -228,7 +228,7 @@ export function inferType(descriptor: unknown): GeneratedOption['type'] {
if (value === 'integer') {
return 'number';
}
if (value === 'string' || value === 'number' || value === 'boolean' || value === 'array') {
if (value === 'string' || value === 'number' || value === 'boolean' || value === 'array' || value === 'object') {
return value;
}
return undefined;
Expand Down