-
Notifications
You must be signed in to change notification settings - Fork 207
feat: list command enhancements with tool filtering and brief output #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuhp
wants to merge
8
commits into
steipete:main
Choose a base branch
from
yuhp:feature/list-command-enhancements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a969377
feat(cli): enhance list command with --brief and filter
yuhp b6b7d52
fix(cli): correct argument parsing for ephemeral servers
yuhp cb7a6bc
docs: update help and README for list command enhancements
yuhp 34e29cb
test: fix list flag parsing tests for brief flag
yuhp b0e0e5f
chore: update .gitattributes for binary files
yuhp 72d24ef
fix(cli): make --brief and --json mutually exclusive in list command
yuhp 849ec69
Merge upstream/main into feature/list-command-enhancements
yuhp 9576dfa
chore: fix lint and formatting issues after merge
yuhp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| * text eol=lf | ||
| *.png binary | ||
| *.tar.gz binary | ||
| *.gz binary | ||
| *.tgz binary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { minimatch } from 'minimatch'; | ||
|
|
||
| /** | ||
| * Filter tools by a glob pattern matching tool names. | ||
| * @param tools Array of items with a `name` property | ||
| * @param pattern Glob pattern to match against tool names | ||
| * @returns Filtered array of tools matching the pattern | ||
| */ | ||
| export function filterToolsByPattern<T extends { name: string }>(tools: T[], pattern: string): T[] { | ||
| return tools.filter((tool) => minimatch(tool.name, pattern, { nocase: true })); | ||
| } | ||
|
|
||
| /** | ||
| * Check if a pattern contains glob special characters. | ||
| */ | ||
| export function isGlobPattern(pattern: string): boolean { | ||
| return /[*?[\]{}!]/.test(pattern); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
--briefis supplied alongside--json, the handler bypasses JSON output and prints text signatures, then returns early. That breaks callers that rely on--jsonfor machine-readable output (e.g.,mcporter list server --json --brief), because the format silently changes to plain text. Either treat--briefas mutually exclusive with--jsoninextractListFlags, or emit a JSON payload for brief mode so the--jsoncontract is preserved.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this by making
--briefand--jsonmutually exclusive in [extractListFlags]. Supplying both will now throw an error with a clear message, ensuring the--jsoncontract isn't silently broken.I've also updated the following to reflect this change:
README.mddocs/cli-reference.md