test: add CORS allowlist edge-case coverage#142
Merged
steipete merged 2 commits intosteipete:mainfrom Mar 12, 2026
Merged
Conversation
Follow-up to steipete#108. Adds 21 additional test cases covering: - Localhost variants: portless, HTTPS, alternate ports, IPv6 without port - Case-insensitive extension protocols (CHROME-EXTENSION, MOZ-EXTENSION, etc.) - Bypass attempts: subdomain spoofing (localhost.evil.com), adjacent loopback IPs (127.0.0.2, 0.0.0.0), protocol injection (javascript:, data:), extension prefix spoofing (chrome-extension-evil://), the literal string 'null', and empty origin - Full CORS header shape assertion for trusted origins
2c0e01e to
17672e0
Compare
Owner
|
Landed via temp rebase onto main.
Thanks @sebastiondev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #108 — adds 21 additional edge-case tests for
isTrustedOriginandcorsHeaders.New coverage (beyond the existing 12 tests):
CHROME-EXTENSION://,MOZ-EXTENSION://, etc.http://localhost.evil.com,http://localhost.evil.com:8787http://127.0.0.2:8787,http://0.0.0.0:8787javascript:alert(1),data:text/html,...chrome-extension-evil://abc"null", empty stringAll 33 tests pass. Full
pnpm check(format + lint + 1568 tests) green.