fix: Inaccurate Summary When Youtube Videos Have No Transcript Enabled#148
Merged
steipete merged 2 commits intosteipete:mainfrom Mar 12, 2026
Conversation
2d3c6c4 to
8994739
Compare
Owner
|
Landed via temp rebase onto main.
Thanks @bytrangle! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#fixes #140
Problem Description
When given a Youtube video without CC (Closed Caption) enabled, this app will try to use
yt-dlpto download the video, then use a model to transcribe and summarize it. However, if the user specifies Gemini as the model,yt-dlpand transcription are skipped and the app defaults to a summary based on the HTML page description.Root Cause
geminiApiKeywasn't passed totranscriptionobject when callingcreateLinkPreviewClientinrunUrlFlow. This causedresolveTranscriptionConfigto resolvegeminiApiKeyas null, makinghasAnyProviderfalse and thereforecanRunYtDlpfalse. Soyt-dlpis never started.Test the new changes
pnpm build