Conversation
|
Landed via temp rebase onto main.
Thanks @steipete! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8e4183785
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (trimmed.endsWith(" do")) { | ||
| depth += 1; | ||
| continue; | ||
| } | ||
| if (trimmed === "end") { | ||
| depth -= 1; |
There was a problem hiding this comment.
Count non-
do Ruby blocks when skipping platform sections
skipDoBlock increases depth only for lines ending in do but decreases depth for every end, so an on_macos/on_linux block containing if/unless/case can terminate early at an inner end. In that case stripExistingPlatformConfig leaves the outer end in place, and updateFormulaForMacArtifacts writes malformed Ruby with an extra end, breaking formula generation for that release.
Useful? React with 👍 / 👎.
Fixes #147.
What changes
odiemessage that points users to npmVerification
pnpm vitest run tests/release.formula.test.tspnpm -s check