Skip to content

fix: guard Homebrew installs on Linux#151

Merged
steipete merged 1 commit intomainfrom
fix/issue-147-homebrew-linux-guard
Mar 13, 2026
Merged

fix: guard Homebrew installs on Linux#151
steipete merged 1 commit intomainfrom
fix/issue-147-homebrew-linux-guard

Conversation

@steipete
Copy link
Owner

Fixes #147.

What changes

  • rewrite generated formulas into a canonical macOS-only shape
  • add an explicit Linux odie message that points users to npm
  • add regression coverage for the guarded formula layout
  • clarify release/docs language around Homebrew being macOS-only today

Verification

  • pnpm vitest run tests/release.formula.test.ts
  • pnpm -s check

@steipete steipete merged commit cdaa99b into main Mar 13, 2026
4 checks passed
@steipete
Copy link
Owner Author

Landed via temp rebase onto main.

  • Gate: pnpm vitest run tests/release.formula.test.ts and pnpm -s check
  • Land commit: c8e4183785f76bcbe457956fa8cc78d42e81b280
  • Merge commit: cdaa99b34f2dabe591938bf457a4d113bf4d3562

Thanks @steipete!

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8e4183785

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +11 to +16
if (trimmed.endsWith(" do")) {
depth += 1;
continue;
}
if (trimmed === "end") {
depth -= 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Count non-do Ruby blocks when skipping platform sections

skipDoBlock increases depth only for lines ending in do but decreases depth for every end, so an on_macos/on_linux block containing if/unless/case can terminate early at an inner end. In that case stripExistingPlatformConfig leaves the outer end in place, and updateFormulaForMacArtifacts writes malformed Ruby with an extra end, breaking formula generation for that release.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homebrew formula installs macOS binary on Linux x86_64

1 participant