Skip to content

fix: honor openai.useChatCompletions in agent mode#156

Open
WinnCook wants to merge 2 commits intosteipete:mainfrom
WinnCook:codex/agent-chat-completions
Open

fix: honor openai.useChatCompletions in agent mode#156
WinnCook wants to merge 2 commits intosteipete:mainfrom
WinnCook:codex/agent-chat-completions

Conversation

@WinnCook
Copy link
Contributor

Summary

  • route daemon agent OpenAI models through the shared OpenAI resolver so sidepanel chat honors openai.useChatCompletions
  • preserve custom OPENAI_BASE_URL behavior for OpenAI-compatible servers
  • add daemon agent regression coverage for env, config, base URL, and streaming agent paths

Closes #155.

Validation

  • pnpm -s check
  • full Vitest suite passed during pnpm -s check (345 files passed, 26 skipped)

Notes

  • kept the change scoped to the agent resolver and its tests only
  • did not add new user-facing flags or settings
  • no reporter follow-up comment posted in this pass

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d46c63f000

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Browser extension sidepanel chat doesn't respect openai.useChatCompletions

1 participant