chore: pin the Node version in .nvmrc and read it from CI (closes #93) - #217
Open
dchaudhari7177 wants to merge 1 commit into
Open
chore: pin the Node version in .nvmrc and read it from CI (closes #93)#217dchaudhari7177 wants to merge 1 commit into
dchaudhari7177 wants to merge 1 commit into
Conversation
…llar-compliance-kit#93) Adds a root .nvmrc so `nvm use` gives contributors the same Node CI runs, and points actions/setup-node at it via node-version-file in both workflow jobs. Pinned to 20, matching the version CI already used and the `engines.node` floor of >=20.0.0 in package.json. Both jobs previously carried a single-entry `node-version: [20.x]` matrix. Those are removed rather than left alongside the file: keeping them would mean two places to bump, which is exactly the drift .nvmrc is meant to prevent. The matrix had one entry, so no build coverage is lost - if a real multi-version matrix is wanted later, .nvmrc still serves as the local default. CONTRIBUTING's "Node 20+" line now points at .nvmrc as the exact version. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93.
Adds a root
.nvmrcsonvm usegives contributors the same Node that CI runs, and pointsactions/setup-nodeat it vianode-version-file— in both workflow jobs, not just the first.Pinned to 20, matching the version CI already used and the
engines.nodefloor of>=20.0.0inpackage.json.One judgement call
Both
test-unitandtest-e2ecarried a single-entrynode-version: [20.x]matrix. I removed them rather than leaving them alongside the new file — keeping both would mean two places to bump, which is exactly the drift.nvmrcexists to prevent.No build coverage is lost: the matrix had one entry. If a real multi-version matrix is wanted later it can come back, with
.nvmrcstill serving as the local default. Happy to restore it if you'd rather keep the matrix shape.CONTRIBUTING.md's "TypeScript, Node 20+" line now points at.nvmrcfor the exact version.Verified the workflow still parses (
yaml.safe_load) and that nostrategy:block remains in either job.🤖 Generated with Claude Code