fix(build): repair yarn build:translations + stop pre-commit hook swallowing its failure

.husky/addTranslations.sh

@@ -1,4 +1,9 @@
 #!/bin/sh
+set -e
 
+# Regenerate the locale catalogs from `t()` calls in the source, then stage them.
+# `set -e` matters: without it a failing build (e.g. a webpack config error) is
+# swallowed, `git add` still runs, and the hook reports success while silently
+# skipping catalog generation entirely.
 yarn build:extension:translations
-git add extension/src/popup/locales/
+git add extension/src/popup/locales/

extension/src/popup/locales/en/translation.json

@@ -666,8 +666,8 @@
   "This site does not appear safe for the following reasons": "This site does not appear safe for the following reasons",
   "This site has been flagged with potential concerns": "This site has been flagged with potential concerns",
   "This site was flagged as malicious": "This site was flagged as malicious",
-  "This token already has a trustline added.": "This token already has a trustline added.",
   "This site was flagged as suspicious": "This site was flagged as suspicious",
+  "This token already has a trustline added.": "This token already has a trustline added.",
   "This token does not appear safe for the following reasons.": "This token does not appear safe for the following reasons.",
   "This token does not support muxed address (M-) as a target destination.": "This token does not support muxed address (M-) as a target destination.",
   "This token has been flagged as malicious for the following reasons.": "This token has been flagged as malicious for the following reasons.",
@@ -698,8 +698,8 @@
   "To receive {{tokenCode}}, your wallet needs a trustline on Stellar.": "To receive {{tokenCode}}, your wallet needs a trustline on Stellar.",
   "To start using this account, fund it with at least 1 XLM.": "To start using this account, fund it with at least 1 XLM.",
   "Toggle Assets": "Toggle Assets",
-  "Token address": "Token address",
   "Token": "Token",
+  "Token address": "Token address",
   "Token Code": "Token Code",
   "Token discovery is temporarily unavailable. You can still swap between tokens you already hold.": "Token discovery is temporarily unavailable. You can still swap between tokens you already hold.",
   "Token ID": "Token ID",

extension/src/popup/locales/pt/translation.json

@@ -666,8 +666,8 @@
   "This site does not appear safe for the following reasons": "Este site não parece seguro pelos seguintes motivos",
   "This site has been flagged with potential concerns": "Este site foi sinalizado com possíveis preocupações",
   "This site was flagged as malicious": "Este site foi marcado como malicioso",
-  "This token already has a trustline added.": "Este token já tem uma trustline adicionada.",
   "This site was flagged as suspicious": "This site was flagged as suspicious",
+  "This token already has a trustline added.": "Este token já tem uma trustline adicionada.",
   "This token does not appear safe for the following reasons.": "Este token não parece seguro pelos seguintes motivos.",
   "This token does not support muxed address (M-) as a target destination.": "Este token não suporta endereço muxed (M-) como destino.",
   "This token has been flagged as malicious for the following reasons.": "Este token foi marcado como malicioso pelos seguintes motivos.",
@@ -698,8 +698,8 @@
   "To receive {{tokenCode}}, your wallet needs a trustline on Stellar.": "Para receber {{tokenCode}}, sua carteira precisa de uma linha de confiança na Stellar.",
   "To start using this account, fund it with at least 1 XLM.": "Para começar a usar esta conta, financie-a com pelo menos 1 XLM.",
   "Toggle Assets": "Alternar Ativos",
-  "Token address": "Endereço do token",
   "Token": "Token",
+  "Token address": "Endereço do token",
   "Token Code": "Token Code",
   "Token discovery is temporarily unavailable. You can still swap between tokens you already hold.": "A descoberta de tokens está temporariamente indisponível. Você ainda pode trocar entre tokens que já possui.",
   "Token ID": "ID do Token",

extension/webpack.extension.js

@@ -1,6 +1,12 @@
 const { merge } = require("webpack-merge");
 const webpack = require("webpack");
-const I18nextWebpackPlugin = require("i18next-scanner-webpack");
+// i18next-scanner-webpack is published as transpiled ESM, so the plugin comes
+// back on `.default` under CommonJS require. Without the unwrap, `new
+// I18nextWebpackPlugin(...)` throws "is not a constructor" and
+// `yarn build:translations` fails at config load.
+const i18nextScannerWebpack = require("i18next-scanner-webpack");
+const I18nextWebpackPlugin =
+  i18nextScannerWebpack.default || i18nextScannerWebpack;
 const { commonConfig } = require("./webpack.common.js");
 const Dotenv = require("dotenv-webpack");
 const dotenv = require("dotenv");