Skip to content

fix(styles): replace undefined --font-weight-* vars with SDS tokens #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CassioMG wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(styles): replace undefined --font-weight-* vars with SDS tokens #2946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension/src/popup/basics/TransactionHeading/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.TransactionHeading {
border-bottom: 1px solid var(--sds-clr-gray-03);
font-size: 0.875rem;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
line-height: 0.72rem;
margin-bottom: 1rem;
padding-bottom: 1rem;
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/basics/buttons/BackButton/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

&__copy {
font-size: 0.875rem;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
margin-left: 0.5rem;
text-transform: uppercase;
}
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/AssetListRow/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
&__code {
color: var(--sds-clr-gray-12);
font-size: pxToRem(16px);
font-weight: var(--font-weight-regular);
font-weight: var(--sds-fw-regular);
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/BlockaidBanner/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
// both render text larger and in a different family.
&__message {
font-size: pxToRem(12px);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
line-height: pxToRem(18px);
text-align: left;
}
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/InternalTransaction/EditMemo/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

&--warning {
color: var(--sds-clr-amber-11);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}
}

Expand Down
4 changes: 2 additions & 2 deletions extension/src/popup/components/InternalTransaction/FeesPane/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
}

&__Label {
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
color: var(--sds-clr-gray-11);

&--total {
Expand All @@ -80,7 +80,7 @@
}

&__Value {
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
color: var(--sds-clr-gray-12);

&--total {
Expand Down
6 changes: 3 additions & 3 deletions extension/src/popup/components/InternalTransaction/ReviewTransaction/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
&__Title {
color: var(--sds-clr-gray-12);
font-size: pxToRem(18px);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
margin-bottom: pxToRem(4px);
}

Expand Down Expand Up @@ -416,7 +416,7 @@
width: 100%;
margin: pxToRem(12px) 0;
font-size: pxToRem(20px);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}

&__Content {
Expand Down Expand Up @@ -471,7 +471,7 @@
align-items: center;
gap: pxToRem(8px);
font-size: pxToRem(12px);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
line-height: pxToRem(18px);
text-align: left;
}
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/ModalInfo/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
color: var(--color-red-70);
display: flex;
font-size: 0.875rem;
font-weight: var(--font-weight-semi-bold);
font-weight: var(--sds-fw-semi-bold);
justify-content: center;
line-height: 1.25rem;
text-align: center;
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/Notification/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
}

&__header {
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
font-size: 1rem;
line-height: 1.5rem;
color: var(--sds-clr-gray-12);
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/SubviewHeader/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

&--title {
flex-grow: 1;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
text-align: center;
}

Expand Down
4 changes: 2 additions & 2 deletions extension/src/popup/components/WarningMessages/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@
}

&__header {
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
font-size: 1rem;
line-height: 1.5rem;
color: var(--sds-clr-gray-12);
Expand Down Expand Up @@ -615,7 +615,7 @@
}

.Message {
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}

.ScanLabel__Action svg {
Expand Down
6 changes: 3 additions & 3 deletions extension/src/popup/components/account/AccountAssets/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ $loader-light-color: #444961;
align-items: center;
justify-content: center;
font-size: 0.875rem;
font-weight: var(--font-weight-semi-bold);
font-weight: var(--sds-fw-semi-bold);
line-height: 1.5rem;
color: var(--sds-clr-gray-12);
}
Expand Down Expand Up @@ -118,7 +118,7 @@ $loader-light-color: #444961;
&__copy-left {
min-width: 0;
display: flex;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);

.asset-icon {
display: flex;
Expand Down Expand Up @@ -146,7 +146,7 @@ $loader-light-color: #444961;

&__copy-right {
min-width: 0;
font-weight: var(--font-weight-regular);
font-weight: var(--sds-fw-regular);

.asset-usd-amount {
text-align: right;
Expand Down
4 changes: 2 additions & 2 deletions extension/src/popup/components/account/AccountHeader/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
&__network-copy {
font-size: pxToRem(14px);
line-height: 1.5rem;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
white-space: nowrap;
}

Expand Down Expand Up @@ -86,7 +86,7 @@

&__account-name {
color: var(--sds-clr-gray-11);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
margin: 0 pxToRem(4px);
}

Expand Down
4 changes: 2 additions & 2 deletions extension/src/popup/components/account/AddWallet/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@
color: var(--sds-clr-gray-12);
font-size: pxToRem(14px);
line-height: pxToRem(20px);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}

&__description {
margin-top: pxToRem(4px);
color: var(--sds-clr-gray-11);
font-size: pxToRem(12px);
line-height: pxToRem(18px);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}
}
}
4 changes: 2 additions & 2 deletions extension/src/popup/components/account/AssetDetail/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
align-items: center;
display: flex;
font-size: 2rem;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
line-height: 150%;

&--isSuspicious {
Expand Down Expand Up @@ -294,7 +294,7 @@

&__label {
font-size: 0.875rem;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}

&__background {
Expand Down
4 changes: 2 additions & 2 deletions extension/src/popup/components/accountHistory/TransactionDetail/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
border-bottom: 1px solid var(--sds-clr-gray-04);
color: var(--color-white);
font-size: 2rem;
font-weight: var(--font-weight-light);
font-weight: var(--sds-fw-light);
padding-bottom: 1.5rem;
text-align: center;
white-space: nowrap;
Expand Down Expand Up @@ -380,7 +380,7 @@
}

.AssetDiff__value {
font-weight: var(--sds-font-weight-medium);
font-weight: var(--sds-fw-medium);

&.credit {
color: var(--sds-clr-green-11);
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/accountMigration/basics/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@

&__name {
color: var(--color-white);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}

&__identicon-wrapper {
Expand Down
6 changes: 3 additions & 3 deletions extension/src/popup/components/amount/AmountCard/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,15 @@
&__amount-label-usd {
font-size: pxToRem(24px);
line-height: 1;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
color: var(--sds-clr-gray-12);
flex-shrink: 0;
}

&__input-amount {
font-size: pxToRem(24px);
line-height: 1;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
color: var(--sds-clr-gray-12);
background: none;
border: none;
Expand Down Expand Up @@ -175,7 +175,7 @@

&__asset-code {
font-size: pxToRem(14px);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}

&__balance-row {
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/identicons/AccountListIdenticon/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
overflow: hidden;
text-overflow: ellipsis;
width: 100%;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}

&__account-num {
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/manageAssets/ManageAssetRowButton/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

&__label {
font-size: 0.875rem;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}

&__ellipsis {
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/manageAssets/ManageAssetRows/ChangeTrustInternal/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@

&__label {
font-size: 0.875rem;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}

&__background {
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/manageNetwork/NetworkForm/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
&__modal {
&__title {
color: var(--color-white);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
text-transform: uppercase;
}

Expand Down
4 changes: 2 additions & 2 deletions extension/src/popup/components/manageNetwork/NetworkSettings/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ $activeColor: rgba(61, 204, 152, 1);
&__header {
color: var(--sds-clr-gray-11);
font-size: pxToRem(14px);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
margin-bottom: pxToRem(16px);
margin-top: pxToRem(32px);
}
Expand All @@ -15,7 +15,7 @@ $activeColor: rgba(61, 204, 152, 1);
align-items: center;
display: flex;
font-size: 0.875rem;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);

&--active {
color: $activeColor;
Expand Down
2 changes: 1 addition & 1 deletion extension/src/popup/components/mnemonicPhrase/DisplayMnemonicPhrase/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
&__content {
font-size: 1rem;
line-height: 1.5rem;
font-weight: var(--font-weight-regular);
font-weight: var(--sds-fw-regular);

p {
color: var(--sds-clr-gray-12);
Expand Down
12 changes: 6 additions & 6 deletions extension/src/popup/components/send/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,22 +92,22 @@

&__amount-label {
font-size: 2.5rem;
font-weight: var(--font-weight-light);
font-weight: var(--sds-fw-light);
margin-left: pxToRem(6px);
}

&__amount-label-usd {
font-size: pxToRem(24px);
line-height: 1;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
color: var(--sds-clr-gray-12);
flex-shrink: 0;
}

&__input-amount {
font-size: pxToRem(24px);
line-height: 1;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
color: var(--sds-clr-gray-12);
background: none;
border: none;
Expand Down Expand Up @@ -273,7 +273,7 @@

&__asset-code {
font-size: pxToRem(14px);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
}

&__balance-row {
Expand Down Expand Up @@ -353,7 +353,7 @@
margin-top: 1.5rem;
font-size: 0.875rem;
line-height: 1.375rem;
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
color: var(--sds-clr-gray-11);

svg {
Expand Down Expand Up @@ -384,7 +384,7 @@
font-size: 0.875rem;
line-height: 1.375rem;
color: var(--sds-clr-gray-12);
font-weight: var(--font-weight-medium);
font-weight: var(--sds-fw-medium);
background: none;
border: 0;
display: flex;
Expand Down
Loading
Loading