SPIKE: Protocol 28 (CAP-0084)#5960
Closed
sisuresh wants to merge 3 commits into
Closed
Conversation
…ndling Bump stellar-xdr to 7b56181 (Protocol 28 / CAP-0084) with XDR_FEATURES=CAP_0083,CAP_0084_MUXED_CONTRACT. Regen adds the SC_ADDRESS_TYPE_MUXED_CONTRACT arm to the ScAddress union. Update the exhaustive hand-written ScAddress switches in xdr/scval.go (String/Equals) to handle the muxed-contract arm so they no longer error/panic. SDK event parsing (extractAddress, parseBalanceChangeEvent) returns the underlying base contract address for muxed-contract destinations; surfacing the muxed id is deferred to horizon.
This was referenced Jun 27, 2026
Commit 51284c1 bumped the .x sources to 787382e but did not fully regenerate gxdr/. Rerunning go generate picks up the corrected SorobanTransactionMetaExtV1.RentFeeCharged doc comment (totalNonRefundableResourceFeeCharged -> totalRefundableResourceFeeCharged), fixing the `check` (gogenerate diff) CI job. Comment-only; no behavior change.
Contributor
Author
|
Closing — this stack will be regenerated from scratch by the automated protocol-release flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
XDR_COMMITto stellar-xdr@7b56181(Protocol 28 / CAP-0084);XDR_FEATURES = CAP_0083,CAP_0084_MUXED_CONTRACT.make xdrregen: addsSC_ADDRESS_TYPE_MUXED_CONTRACTarm +MuxedContractstruct to theScAddressunion (only.xdelta vs CAP-0083 base).xdr/scval.go: handle the new muxed-contract arm in the exhaustiveScAddress.String()/ScAddress.Equals()switches (previously errored/panicked on the new arm).MuxedContractcase inxdr/scval_test.go;processors/token_transfertest asserting muxed-contract event parsing doesn't panic.Deferred
extractAddress/parseBalanceChangeEvent) returns the underlying base contract address (no panic, no dropped events). There is no strkey encoding for muxed contracts in this package yet; surfacing the muxed id intoMuxedInfois left to horizon's processor (mirrors how the muxed-account work was scoped).MaxSupportedProtocolVersion), so no version bump.Upstream: stellar/stellar-xdr#306 · stellar/rs-stellar-xdr#549 · stellar/rs-soroban-env#1696 · stellar/rs-soroban-sdk#1922 · stellar/stellar-core (sisuresh#18)