horizon: improve cnpg credential handling - #181
Merged
Merged
Conversation
Currently creds can't be provided via pre-exisitng secret - they have to come
from the values file.
This PR makes it possible to provide existing secret via the following:
```
cnpg:
cluster:
spec:
bootstrap:
initdb:
secret:
name: cnpg-db-creds
```
Original method is still active so the changes should be backwards compatible
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for existing CloudNativePG bootstrap secrets while preserving chart-managed credentials.
Changes:
- Conditionally renders CNPG and database credentials.
- Adds configuration validation and username defaults.
- Documents external-secret usage and bumps the chart version.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
charts/horizon/values.yaml |
Documents credential options. |
charts/horizon/templates/database-secret.yaml |
Gates database secret generation. |
charts/horizon/templates/cnpg-cluster.yaml |
Invokes credential validation. |
charts/horizon/templates/cnpg-app-secret.yaml |
Skips managed credentials for custom bootstrap. |
charts/horizon/templates/_helpers.tpl |
Adds validation and credential fallback logic. |
charts/horizon/templates/_cnpg.tpl |
Preserves user-provided bootstrap configuration. |
charts/horizon/README.md |
Documents existing-secret setup. |
charts/horizon/Chart.yaml |
Bumps chart version to 0.8.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jonathan-Eid
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently creds can't be provided via pre-exisitng secret - they have to come from the values file.
This PR makes it possible to provide existing secret via the following:
Original method is still active so the changes should be backwards compatible